Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No warning about a content element having references if trying to delete with inline delete button #45

Open
sypets opened this issue Jul 23, 2023 · 1 comment · May be fixed by #60
Open

No warning about a content element having references if trying to delete with inline delete button #45

sypets opened this issue Jul 23, 2023 · 1 comment · May be fixed by #60

Comments

@sypets
Copy link
Contributor

sypets commented Jul 23, 2023

The behaviour was improved in TYPO3 v12, there is also a patch for v11 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/80116), applying this patch with composer-patches does not help if gridelements is installed because gridelements overrides the core behaviour

Also, the dialog displayed by gridelements is not localized (always displayed in English).

Reproduce

  1. create a content element, e.g. "textmedia" [1]
  2. create a shortcut element, referencing the first element [2]
  3. try to delete the first element (which has references) using the inline delete buttons in the page module

Versions

  • gridelements: 11.0.0, also reproduced with latest "master"
  • TYPO3 core: 11.5.29

Screenshots

delete via this button in page module

image

Intended behaviour:

image

Current behaviour:

image

Related core issues
@sypets
Copy link
Contributor Author

sypets commented Nov 22, 2023

I can still reproduce it that the message is displayed in English if BE is in German with latest master in TYPO3 v11.5.33

image

sypets added a commit to sypets/gridelements that referenced this issue Nov 22, 2023
@sypets
Localize text which is displayed in model dialog
4c4eb40 
Make sure the text which is displayed in the modal
dialog when warning about deleting ce with references
is localized.

This reuses some code from TYPO3 v11 which is not yet
available in TYPO3 v10 and was introduced in patch
https://review.typo3.org/c/Packages/TYPO3.CMS/+/80116

Resolves: CodersCare#45
This was referenced Nov 22, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Localize text which is displayed in modal dialog sypets/gridelements
1 participant
@sypets