-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update android plugin instructions #254
Update android plugin instructions #254
Conversation
To use new and current bridgeBuilder.addPlugin() method over depreciated and removed init().
@teaqu thx for PR :) |
Hey reslear I unfortunately also have limited Java / android experience however everything else seems OK. I have it running on an emulator and appears to work correctly following the instructions, this was the only change I had to make. |
Updated pull request to use suggested method in https://github.com/ionic-team/capacitor/blob/3.x/android/capacitor/src/main/java/com/getcapacitor/BridgeActivity.java (see doc for init()). |
@teaqu thx |
Plugin Registration isn't needed anymore since capacitor 3. Lots of plugins removed java part from the docs. See here: https://capacitorjs.com/docs/updating/3-0#switch-to-automatic-android-plugin-loading So is the registration in MainActivity really required for this plugin? |
@mariusbolik could have checked ? |
@reslear Plugin is registered correctly along all other Plugins, without putting it in MainActivity.java. I just checked in Logcat: |
@mariusbolik Okay, what's the plan? |
You cloud update the Documentation and remove the Part where the User should add the Code to |
@mariusbolik cool, could you open a PR ? |
Yeah seems to work without for me too created a pull request. |
Hello,
For android, this.init() has been depreciated for a while and is not even usable in the latest capacitor.
I've updated the readme with the new way to add plug-ins.