Upgrade to Capacitor 6

[KerimM]

closes #354
closes #356

[reslear]

thi is already cap6 verision, please change to 3.4.0-rc.1

[KerimM]

Done

[reslear]

I'll have to remember to return #345.

[KerimM]

I'll have to remember to return #345.

done

[reslear]

@KerimM thank you 🔥

[ManuelCostanzo]

Hey, sorry I have a question, why are you doing

CAP_PLUGIN(GoogleAuth, "GoogleAuth")

when that macro needs three params?

[reslear]

hi @ManuelCostanzo That's not right, can you create a revert PR?

[KerimM]

Hey, sorry I have a question, why are you doing

CAP_PLUGIN(GoogleAuth, "GoogleAuth")

when that macro needs three params?

I follow the migration guide

Breaking changes in code
iOS
Remove removeAllListeners method
If you plugin had CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnPromise); in the .m file, it can be removed now, the method is now available for all plugins without defining it.

[reslear]

@KerimM maybe need remove only core method removeAllListeners ?)

like:

https://github.com/Cap-go/capacitor-updater/blob/3a8da63fe2bc0b4ad2df7268fb057a2b204e01c1/ios/Plugin/CapacitorUpdaterPlugin.m#L29

[gasci]

Is there an update regarding this topic? 3.4.0-rc.1 fails @KerimM

[reslear]

hi @gasci check please v3.4.0-rc.2

[gasci]

For some reason rc.2 isn't available. Am I doing something wrong?

The most recent version is the one here for some reason.

Edit
The method below worked:
npm install "CodetrixStudio/CapacitorGoogleAuth#v3.4.0-rc.2"

[gasci]

I confirm that v3.4.0-rc.2 works with capacitor version 6.0.0. Could you release v3.4.0-rc.2 as version 6.0.0 for this plugin to align with the capacitor version, please? @reslear

Other community plugins mostly follow this convention.

[reslear]

done, published 3.4.0-rc.3

[mburger81]

When will we see this plugin as stable release for capacitor@6, thx you a lot for your work

[gasci]

I believe it is breaking on M1 computers and there a few major bugs that prevent this plugin to be stable for now. @mburger81

I created issues as I detect them:
#363

[mburger81]

Ok but this issue has as source the @capacitor@6 update? @gasci if yes thats obviously bad, thx for your response

[gasci]

I believe that is the case. It started to occur after my capacitor6 upgrade for this plugin

[mburger81]

@gasci it seems you have fixed the problem here
#363 (comment)

so we should be able to have a stable release?

[gasci]

I would say so. Yes, calling the init methods before others fixes the issue. @mburger81

[mburger81]

@gasci can we have a official release for capacitor@6? I mean at the end of august you can't upload to Gogole Play Store if you don't use Android14+ which means for use to upgrade to capacitor@6.

[gasci]

Hi, I don't think I have the permissions to do that. Please reach out to the original maintainers.

[mburger81]

Oh yea thats true, sorry @gasci

@KerimM @reslear can you please do a official release without the -rc.x ?

[reslear]

@mburger81 you have to test it first

[gasci]

I tested this version and I am running it without any problems. (3.4.0-rc.4)

But please see this issue if you are having issues on tablets and M1 computers:
#363