Improvement/bump gms google auth version #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing other folks resolve the
below error by updating the google-play SDK version, I made a change that increases default version to latest and allows clients to override this setting.
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.XXXXX/com.google.android.gms.auth.api.signin.internal.SignInHubActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
firebase/firebase-android-sdk#5768
Also, added a check if gapi initialized correctly using
initialize
method.As seen on issue #364, this also fixes crashes happens when
signIn
&signOut
called before the initialization.Instead of crashing, the plugin is now able to reject the promise gracefully.
ref: https://github.com/react-native-google-signin/google-signin/blob/f5ef438aeda0c40f68082dc0b1bddc04bbd6298c/android/src/main/java/com/reactnativegooglesignin/RNGoogleSigninModule.java#L174