Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleSignIn pod to 7.1.0 #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafael-rentman
Copy link

Updated the GoogleSignIn dependency to:

  • include necessary privacy manifests
  • ensure compatibility with newer Google MLKit based capacitor plugins (E.G. @capacitor-mlkit/barcode-scanning)

@reslear
Copy link
Collaborator

reslear commented Oct 18, 2024

thank you for your work :)

is it worth changing anything for andoid /web ?
should something be added to the readme ?
Were you able to test locally ?

@rafael-rentman
Copy link
Author

Glad to help!

  • As far as I know there are no dependency issues on the android/web side
  • Sharp! Yes, a small change in configuration: for iOS it's now required to add the clientId of the app to the .plist, I will update the readme
  • I have tested the package in our app on an actual device using xcode, logged in users stay logged in, logging in/out works as expected.

@reslear
Copy link
Collaborator

reslear commented Oct 18, 2024

Good, I'm guessing it's breaking change

By the way, can you add a link to the official documentation about GIDClientID?

@riderx
Copy link
Contributor

riderx commented Oct 18, 2024

@rafael-rentman people do depend on the ability to have a runtime defined GID
So if it's required to have it, then the runtime google GID for android should be removed and noted as deprecated.
Link: https://developers.google.com/identity/sign-in/ios/release

@rafael-rentman
Copy link
Author

rafael-rentman commented Oct 24, 2024

@rafael-rentman people do depend on the ability to have a runtime defined GID So if it's required to have it, then the runtime google GID for android should be removed and noted as deprecated. Link: https://developers.google.com/identity/sign-in/ios/release

Fair enough, I will take a closer look.

@riderx Can you name some examples of situations where a runtime defined GID is necessary?

@riderx
Copy link
Contributor

riderx commented Oct 25, 2024

For what i have seen, in ealier issue, people want to allow login and api usage with different credentials, so at runtime the connection is done.
This feature has been done not so long ago by some users who needed it, so they would loose this. If possible it’s preferable to keep it

@rafael-rentman
Copy link
Author

Mmh it seems like this will not work with the GoogleSignIn pod going forward. I still don't understand why anyone would want to have multiple GID's for a single app in production... If it is to separate dev from prod it is a non-issue anyway, then it should just be changed in the config

@reslear
Copy link
Collaborator

reslear commented Nov 6, 2024

I still don't understand why anyone would want to have multiple GID's for a single app in production.

Is that how it is now? Can you give me an example? How it was? How it will be.

@riderx
Copy link
Contributor

riderx commented Nov 8, 2024

Mmh it seems like this will not work with the GoogleSignIn pod going forward. I still don't understand why anyone would want to have multiple GID's for a single app in production... If it is to separate dev from prod it is a non-issue anyway, then it should just be changed in the config

For example, connect to different google services if your app connects to one GID for Login and one for calendar.
But the question is not really why, the point is you cannot remove a feature without going a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants