Fixing the LF issue

[kazk]

Fixing the issue where users' output affects the test result.

user logged output<FAILED::>

• Dart
  • Server Execution Error, see the comment below
• C# ([C#] Fix LF issue #411, C# Fix LF Issue (updated compiled assembly) #572)
• JavaScript ([JS/TS/CS] Fix LF Issue #502)
• TypeScript ([JS/TS/CS] Fix LF Issue #502)
• OCaml ([OCaml] Fix LF issue #468)
• Swift (Rewrite Swift runner #451)
• PHP ([PHP] Fix LF issue #421)
• F# ([F#] Fix LF issue #419)
• Elixir ([Elixir] Fix LF issue #417)
• Crystal ([Crystal] Fix LF issue #416)
• Ruby ([Ruby] Fix LF issue #414)
• C++ ([C++] Fix LF issue #413)
• Python ([Python] Fix LF issue #412)
• Lua ([Lua] Add "Preloaded" code support #409)
• Java (Java now forces passed/failed message onto new lines #336)
• Go ([Go] Prepend LF to output commands #339)
• C (@25e5609)

---

• Rust (lib/runners/rust.js) outputs the result differently from the most and not really affected.
  • stdout is transformed after the test and only contains the output commands

    <DESCRIBE::>returns_expected
    <FAILED::>Test Failed
    

  • stderr contains the details on failure (print!("foo"); assert_eq!(1, 2);)

    Failure Info:
    
    ---- returns_expected stdout ----
    	foothread 'returns_expected' panicked at 'assertion failed: `(left == right)` (left: `1`, right: `2`)', main.rs:17
    

---

codewars/codewars.com#867
codewars/codewars.com#937

[kazk]

C# example from @Voileexperiments's comment

using System;
using NUnit.Framework;

[TestFixture]
public class KataTestClass
{
    [Test]
    public void Test()
    {
        Console.Write("foobar");
        Assert.AreEqual(true, false);
    }
}

Outputs

foobar<FAILED::>  Expected: True
  But was:  False

[Voileexperiments]

JS example:

Test.expect(true);
process.stdout.write('foobar');
Test.expect(false);
process.stdout.write('foobar\n');
Test.expect(false);
process.stdout.write('foobar');
Test.expect(false);

Python example:

#Python 2
import sys

test.expect(True)
sys.stdout.write('foo')
test.expect(False;
sys.stdout.write('bar')
test.expect(True)

#Python 3
test.expect(True)
print('foo', end='')
test.expect(False)
print('bar', end='')
test.expect(True)

[Voileexperiments]

Throwing out some ideas:

Is it possible for the runner to detect current stdout? If so, it can then just check if the last character is a line feed, and if not, send one to stdout first.

Or alternatively, send a extra linefeed before the test messages no matter what. This will increases the character count by a bit and doubles the number of lines, but it might totally avert the issue?

[kazk]

Extra line feed will be added (like in bb41dbb).
See @jhoffner's comment in codewars/codewars.com#867.

[kazk]

Causes server execution error in Dart :(

[kazk]

@jhoffner can we move Codewars/mocha-reporter in this repository by updating Mocha?
Mocha v3.3.0 "Adds support for loading reporter from an absolute or relative path" and supports node >= 0.10.x.

[jhoffner]

Sure let's do it.

[kazk]

I found that JavaScript has been tested with mocha installed in base-image at docker/base.docker#L107 and not "mocha": "2.5.3" in package.json#L55.
I think the version has been 3.2.0 for while...