Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use FutureOr to allow synchronous interceptors #144

Merged

Conversation

Leptopoda
Copy link
Contributor

@Leptopoda Leptopoda commented Jun 12, 2024

This allows synchronous implementations for interceptors.

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@CodingAleCR
Copy link
Owner

Interesting, what is your use case?

Also, it would be great if you update the examples and the docs along with the library's code.

Thank you!

@Leptopoda
Copy link
Contributor Author

Sorry for my delay.
The idea is that we mostly use synchronous interceptors so one can add a separate subclass that only allows synchronous methods.
If used in a custom http client one would not get the async suspension.

@CodingAleCR CodingAleCR merged commit f54a401 into CodingAleCR:main Jul 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants