Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"The Coding Train" Footer Logo Being Cut Off. #1759

Closed
coderpro1234-2 opened this issue Nov 6, 2024 · 1 comment · Fixed by #1760
Closed

"The Coding Train" Footer Logo Being Cut Off. #1759

coderpro1234-2 opened this issue Nov 6, 2024 · 1 comment · Fixed by #1760
Assignees
@fturmel
Labels
bug Something isn't working

Comments

@coderpro1234-2
Copy link

On all of the pages, the text that says "The Coding Train" in the footer is cut off at the word "Train". Instead of the width of the svg being 326px, it is 250px.

Screenshot 2024-11-07 at 10-17-59 The Coding Train

Screenshot 2024-11-07 101722
@fturmel fturmel self-assigned this Nov 6, 2024
@fturmel
Copy link
Collaborator

fturmel commented Nov 6, 2024

Thanks for reporting this! I think it's my fault (#1745), strangely svgo removes the svg viewBox attribute by default - which is definitely not a safe operation for a minifier/optimizer to do. PR incoming.

@fturmel fturmel added the bug Something isn't working label Nov 6, 2024
@fturmel fturmel mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fturmel fturmel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep viewBox attribute on optimized SVGs fturmel/thecodingtrain.com
2 participants
@fturmel @coderpro1234-2