Update yeoman dependencies #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmatto
commented
Jan 20, 2017
bmatto
commented
- Use class extends syntax
- Use class extends syntax
Merged
craineum
approved these changes
Jan 20, 2017
| const humps = require('humps') | ||
|
|
||
| module.exports = generators.Base.extend({ | ||
| prompting: function() { | ||
| module.exports = class extends Generator { |
There was a problem hiding this comment.
Should this class have a name for debug-ability/stack traces? Not sure if we'd ever see it.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "generator-react-zeal", | |||
| "version": "0.1.9", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
Minor nit: I normally do a separate commit with a version bump and CHANGELOG update just before doing a release, rather than making it part of another commit. This gives me the flexibility to put multiple commits in a release, and also avoids merge conflicts if I have multiple PRs all trying to bump the version number. Up to you, though.
- Will uptick on release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.