Move lint configuration to react-scripts fork #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2017 10:08
The generated project did not have the test-specific .eslintrc.json file, so was getting lint errors right after generation.
lexun
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were duplicating the list of lint plugins between this project and our react-scripts fork. Now, all lint-related packages are installed via react-scripts, and we run the linter manually using its the new
react-scripts lintcommand.This also gets us up-to-date with the latest eslint-config-zeal and friends.
The one potential issue with this change is the ability to get lint feedback in a text editor, but that seems to be working in our testing. If we run into issues on other systems, we’ll have to revisit.
As part of our testing, we discovered that the generated project did not have the test-specific .eslintrc.json file, so was getting lint errors right after generation. We updated the copy command in the generator to include dotfiles.
We've confirmed that, in a generated project, we get the same output from:
yarn lint:jsyarn startCloses #45
Fixes #48
Fixes #50