Upgrade dependencies to latest versions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since react-toolbox 2 is still beta and hasn't fixed the warnings, I'd be fine saving that upgrade for a later PR. I do really dislike warnings in my console though, and so wouldn't be opposed to leaving this open while we sort things out. Up to you. If you want to keep it open, the phoenix demo app might be a good place to test out the react-toolbox 2 changes. And maybe there is a way we can help with those deprecation warnings in themr and wherever else they're coming from? |
|
For reference, the normalize.css dependency was left over from before we set up react-toolbox: 5c83e23#diff-a1ae10ba834806ea2252e4e950d1b527L5 |
lexun
approved these changes
May 11, 2017
added 11 commits
May 11, 2017 09:04
We don’t use it, so we don’t need it.
There is a breaking API change, but it doesn’t affect us.
This requires replacing react-addons-test-utils with react-test-renderer and react-addons-css-transition-group with react-transition-group. We currently get two warnings: * When running tests and in the browser console: `Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.`. This warning is coming from (at least) the ApolloProvider; we’ll be upgrading that shortly. * When installing packages, we get some peer dependency issues with react-toolbox. We’ll look at resolving those shortly as well.
Remove direct dependency on apollo-client because it is now exported
from react-apollo (as is graphql-tag).
We now do `import { ApolloClient } from ‘react-apollo’` instead of
`import ApolloClient from ‘apollo-client’`.
We don’t use it and it is no longer needed.
randycoulman
force-pushed
the
chores/upgrades
branch
from
badcfb4 to
ee7e719
Compare
Apollo’s redux actions don’t conform to the flux-standard-action spec, but zeal-redux-utils’ `createReducer` throws an error if any non-FSA-compliant actions are dispatched. zeal-redux-utils 0.3.1 now allows a whitelist function to be passed which will bypass the FSA check on whitelisted actions. We add a local `createReducer` function that supplies an appropriate whitelist function for Apollo actions and the use that everywhere. NOTE: This new function makes use of Ramda, so we now include that in this project.
lexun
approved these changes
May 12, 2017
casto101
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-addons-test-utilswithreact-test-rendererandreact-addons-css-transition-groupwithreact-transition-group.apollo-clientbecause it is now exported from react-apollo (as isgraphql-tag). We now doimport { ApolloClient } from ‘react-apollo’instead ofimport ApolloClient from ‘apollo-client’.Upgrade react-toolbox to the 2.0 beta stream. 2.0 does not yet adjust for the React 15.5.x deprecation warnings, but those changes will not happen on the 1.x stream (most likely). However, 2.0 eliminates the use of Sass internally, so we need to figure out how to do our theming in light of that.Notes:
With the React 15.5 upgrade, we currently get two kinds of warnings:
When running tests and in the browser console:
Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.. This warning is coming from (at least) react-css-themr; it has not yet been updated for React 15.5.x.When installing packages, we get some peer dependency issues with react-toolbox. There are PRs on the 2.0 beta track that address these issues, but not all of them have been merged yet. To be fair, we were seeing these even with React 15.4.2.
Closes #46