Allow whitelisting actions for flux-standard-action check #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2017 16:43
Some libraries that dispatch actions through our reducers do not conform to the flux-standard-action spec, but `createReducer` will throw a `NonStandardAction` when encountering those actions. This PR adds allows `createReducer` to take an `allowNonStandardActionIf` predicate that is applied to each action. If the predicate returns true, we no longer check to see if it conforms to the FSA spec.
lexun
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries that dispatch actions through our reducers do not conform to the flux-standard-action spec, but
createReducerwill throw aNonStandardActionwhen encountering those actions.This PR adds allows
createReducerto take anallowNonStandardActionIfpredicate that is applied to each action. If the predicate returns true, we no longer check to see if it conforms to the FSA spec.