Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code blocks instead of suggestion blocks for Bitbucket Server multi-line suggestions #1079

Conversation

MarkRx
Copy link
Contributor

@MarkRx MarkRx commented Jul 30, 2024

User description

Workaround for https://jira.atlassian.com/browse/BSERV-4553

#1076


PR Type

bug fix, enhancement


Description

  • Implemented a workaround for the Bitbucket Server multi-line suggestions issue (BSERV-4553) by replacing suggestion blocks with code blocks.
  • Modified the publish_code_suggestions method in bitbucket_server_provider.py to handle multi-line suggestions correctly.

Changes walkthrough 📝

Relevant files
Bug fix
bitbucket_server_provider.py
Workaround for Bitbucket Server multi-line suggestions issue

pr_agent/git_providers/bitbucket_server_provider.py

  • Added a workaround for Bitbucket Server multi-line suggestions issue.
  • Replaced suggestion blocks with code blocks in the
    publish_code_suggestions method.
  • +2/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    …ti-line suggestions to workaround BSERV-4553
    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🏅 Score: 85
    🧪 No relevant tests
    🔒 No security concerns identified
    🔀 No multiple PR themes
    ⚡ Key issues to review

    Code Clarity
    The replacement of "suggestion" with "" is not clearly explained in the comments. It would be beneficial to add more details about why this change is necessary and how it resolves the issue.

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @mrT23
    Copy link
    Collaborator

    mrT23 commented Aug 1, 2024

    thanks. its not an ideal solution, but I get why its better than the current situation

    @mrT23 mrT23 merged commit 23ec25c into Codium-ai:main Aug 1, 2024
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants