Fixing code suggestions being published when publish ouput is false

[AHancher2022]

User description

resolves #1188

---

PR Type

Bug fix

---

Description

• Fixed a bug where "No code suggestions" message was being published even when publish_output was set to false
• Added a condition to check get_settings().config.publish_output before publishing the message
• This change ensures that the code suggestion output is only published when explicitly configured to do so
• Resolves issue Publish output being set to false still publishes if there are no code suggestions found for PR #1188

---

Changes walkthrough 📝

	Relevant files
Bug fix	pr_code_suggestions.py Fix code suggestion publishing logic                                          pr_agent/tools/pr_code_suggestions.py Modified the condition for logging and publishing "No code suggestions" message Added a check for get_settings().config.publish_output to control message publishing +2/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 95

🧪 No relevant tests

🔒 No security concerns identified

🔀 No multiple PR themes

⚡ Key issues to review Code Clarity The condition for checking if code suggestions exist and if output should be published is complex and could be simplified for better readability.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Reorder condition checks to prioritize the most significant or computationally efficient checks Consider moving the get_settings().config.publish_output check to the beginning of the condition for early exit and improved readability. pr_agent/tools/pr_code_suggestions.py [107-108] -if (data is None or 'code_suggestions' not in data or not data['code_suggestions'] - and get_settings().config.publish_output): +if get_settings().config.publish_output and (data is None or not data.get('code_suggestions')): Apply this suggestion Suggestion importance[1-10]: 8 Why: This suggestion improves both readability and performance by checking the configuration first, potentially avoiding unnecessary checks if publish_output is False.	8
Enhancement	Simplify the condition by using a more concise method to check for the presence and content of a dictionary key Consider simplifying the condition by combining the checks for data and data['code_suggestions'] into a single expression using the get() method. pr_agent/tools/pr_code_suggestions.py [107-108] -if (data is None or 'code_suggestions' not in data or not data['code_suggestions'] - and get_settings().config.publish_output): +if not data.get('code_suggestions') and get_settings().config.publish_output: Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion correctly simplifies the condition using the get() method, which improves readability and reduces code complexity.	7