-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing requirements.txt on lambda dockerfile #826
Conversation
PR Description updated to latest commit (d250cb4)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
User description
The bug resolved by this PR is described in issue #824.
Problem A:
When in commit bc2cf75b7
pyproject.toml
was introduced,requirements.txt
was replaced, which is an error because inside the build containers this file will not be there for the build withpyproject.toml
to work as expected.Problem B:
After solving problem A, when trying to boot the container in Lambda I got again an exception with the trace
Adding git to the image via "yum install" resolved this.
Type
bug_fix
Description
requirements.txt
was missing in the Docker build for Lambda, causing build failures.pyproject.toml
andrequirements.txt
are now copied into the Docker image for successful builds.Changes walkthrough
Dockerfile.lambda
Fix Missing `requirements.txt` in Lambda Dockerfile
docker/Dockerfile.lambda
requirements.txt
to the files copied into the Docker image.