-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make rochester_lookup compatible with dask_awkward #875
Conversation
@ssrothman FYI we got the old version working - we should settle on a plan to correctionlib-ify rochester corrections. The tool in coffea to extract the current rochester corrections into something pythonic should be a good starting point for onboarding since you got a good bit of the rest of it done iiuc. @nsmith- @andrzejnovak @NJManganelli - adding you here since we should keep in mind that we'd like to go this direction (correctionlib rochester) |
Let me put the tests in dask and we'll be good to go I think. |
I fixed the test a bit. The issue was that the first argument to |
Thanks I'll take a look. I had to pause on this to take care of other issues. |
@jrueb just checking in here - the underlying issues in awkward / dask-awkward that are impeding progress here are being worked on my Angus and Jim. But it seems we wait on those for now. |
So with some fixes from awkward and dask-awkward this fails in a different way. I'll keep using this to exercise the changes coming down the pipeline that aim to fix the present failure. |
@jrueb FYI scikit-hep/awkward#2652 now fixes the failures in this PR. |
Before,
rochester_lookup.kSmearMC
androchester_lookup.kSmearMCerror
would not work with dask-awkward arrays. This was because of a call todoublecrystalball.ppf
(scipy) andnumpy.zeros_like
.Fixes #871