[dpy2_unstable] Updates the Red-Lavalink dependency #5628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of this is removing `.replace(...)` which while not technically needed, simplifies the code base. There's only a few changes that are actually necessary here.
Here's the list of the changes that have been made here:
- Documented that `{channel}` in CCs might be a thread
- Prevented usage of threads in `[p]announceset channel`
- Allowed usage of threads in `[p](un)ignore channel`
- Also, threads inherit parent's and parent's category ignore lists
- Made `[p](un)mutechannel` refer to parent in threads
- Made permissions system apply rules of (only) parent in threads
- Allowed (documented) usage of threads with `Config.channel()`
- Separate thread scope is still in the picture though it might be
better to do this in separate PR?
- Prevented settings filter list for threads in Filter cog
- Updated Filter cog to inherit parent channel's filter list in threads
- Prevented settings rules for threads with `[p]permissions`
- Permissions cog does not perform any validation for IDs
when setting through YAML so that has not been touched
- Prevented adding stream alerts for threads
- Fixed assertion error in `bot.message_eligible_as_command()`
- Added support for passing `Thread` to `bot.embed_requested()`
- Threads don't have their own settings and inherit from parent
- Prevented usage of threads in `[p]embedset channel`
- Prevented usage of threads in `[p]set ownernotifications`
- Prevented usage of threads in `[p]diagnoseissues` (more info below)
- Added support for passing `Thread` to `channel` when creating case
- Added `parent_channel_id` attribute to Modlog API's Case
- Updated case's content to show both thread and parent information
- Updated type hints
There are some known missing things:
- `[p]diagnoseissues` does not accept threads (I didn't feel like
writing strings today :))
- Quite a bit of user-facing docstrings refer to current channel
when they also mean thread (should we fix this?).
- Developer-facing docs do too but I don't think that's an issue.
This means adding `override` keyword-only parameter and causing small breakage by swapping RuntimeError with discord.ClientException.
Honestly, this was a rather bad implementation anyway... Breaking but actually not really - it was provisional.
BTW, that should really be in core instead of what we have now...
This is breaking but it's best to resolve it like this. Most (but not all) of the functionality of ConversionFailure can be replicated with Context.current_parameter. It is (currently) impossible to get the equivalent of `ConversionFailure.argument` from d.py alone. If this turns out to be useful, we might try to implement on our own though it would be preferred to have this directly in d.py.
|
Mind that developers are currently unable to install Redbot from the dev branch to prepare for the coming April 30th changes. So maybe it would be better to drop the lavalink dependency down to the current release instead? At least until the changes in #5593 are finalized? Unless you think it's going to be merged really soon. |
was due to be merged yesterday - but Jack raised some concerns and blocked the merge so right now its 🤷 - a quick and easy fix would be reopening the old PR so that you all can install from it. |
Jackenmen
force-pushed
the
V3/dpy2_unstable
branch
from
6f30678 to
1f7365e
Compare
Crossedfall
requested review from
TrustyJAID,
palmtree5,
aikaterna and
PredaaA
as code owners
|
Should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Closing Cog-Creators/Red-Lavalink#99 broke fresh installs for the dpy2 branch. Updating to the superseding PR ( Cog-Creators/Red-Lavalink#122 ) allows pip to install from this branch again.
Have the changes in this PR been tested?
Tested to ensure it installs, I do not know if it breaks anything past that.