Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and complete the secure connection implementation #116

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Fix and complete the secure connection implementation #116

merged 3 commits into from
Mar 15, 2022

Conversation

Drapersniper
Copy link
Contributor

No description provided.

@Drapersniper Drapersniper mentioned this pull request Mar 10, 2022
Merged
Jackenmen
Jackenmen reviewed Mar 15, 2022
View reviewed changes
lavalink/node.py Outdated Show resolved Hide resolved
@Drapersniper Drapersniper requested a review from Jackenmen March 15, 2022 19:24
Jackenmen
Jackenmen approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but does it look good to you?

@Jackenmen Jackenmen merged commit 0c0b653 into Cog-Creators:develop Mar 15, 2022
@Jackenmen Jackenmen self-assigned this Mar 15, 2022
@Jackenmen Jackenmen added this to the 0.10.0 milestone Mar 15, 2022
@Drapersniper Drapersniper deleted the fix_secured branch March 15, 2022 19:32
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 15, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
a612509 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 16, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
2f11cff 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
cc74e23 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 20, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
d566e2e 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 20, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
f053156 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 20, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
64d567c 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
482b539 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
9fa6732 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 28, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
5b2a398 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 29, 2022
@Drapersniper @Jackenmen
Fix and complete the secure connection implementation (Cog-Creators#116)
ed76160 
* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Jackenmen added a commit that referenced this pull request Mar 29, 2022
@Drapersniper @PredaaA
@aikaterna @Jackenmen
Make use of discord.VoiceProtocol instead of socket_response (#122)
b9fe75a 
* WIP discord.VoiceProtocol

* make similar of old socket_response behavior.

* No longer pass voice_ws_func to node

* Cleanup.

* Fix tests.

* More cleanup

* More cleanup

* Fix style.

* hm yeah

* Remove node.get_voice_ws, and replace it with client.is_closed.

* Use Shard.is_closed instead of bot.is_closed.

* Include methods from HTTPClient in Player.

* ... forgot one.

* Put back RESTClient to Player instead of Node.
It needed Player.state to works properly.

* Delete node._remove_player. Use player.disconnect force instead.

* Add discord.py 2.0 changes

* Fix unwanted voice events being passed

* Fix 2/3 tests.

* Reformat.

* Assert from player.

* Simplify this.

* Improve get_channel logic (#112)

* Improve get_channel logic

* Update fixtures

* Style changes

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* Fix and complete the secure connection implementation (#116)

* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* Add Exception classes to RLL (#115)

* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup

* Major rework of shutdown and reconnect logs to avoid zombie tasks and… (#6)

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* conflict resolution with predas

* welp

* Conflict resolution between Develop and PredaaA/Feature/dpy-voiceprotocol

* Add Exception classes to RLL (#115)

* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup

* refix the conflict resolution

* Update lavalink.py

* address jack's review

* typing, docs, style

* address code review

* type the event handler (dispatch)

* Update lavalink/player.py

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* missed this?

* Update lavalink.py

Co-authored-by: PredaaA <46051820+PredaaA@users.noreply.github.com>
Co-authored-by: aikaterna <20862007+aikaterna@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees

@Jackenmen Jackenmen

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Drapersniper @Jackenmen