Save checkpoints during unsupervised training and make it resumable #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-is-h
reviewed
Dec 3, 2021
medcat/cat.py
Outdated
| """ | ||
| if ckpt_max_to_keep < 1: |
There was a problem hiding this comment.
Do not like this, I've rarely (or never) seen this feature
There was a problem hiding this comment.
Checks like this are now wrapped in the decorator.
w-is-h
reviewed
Dec 3, 2021
medcat/cat.py
Outdated
| N.B.: A larger number could result in the out-of-disk-space error. | ||
| num_of_skipped (int): | ||
| The number of sentences/documents to ignore at the beginning. | ||
| is_resumed (bool): |
There was a problem hiding this comment.
Prefer to have it named: resume_from_checkpoint which can be bool/path (have a look at spacy or HF)
mart-r
pushed a commit
to mart-r/MedCAT
that referenced
this pull request
Jun 14, 2023
…ogStack#178) * CAT-92 add the method for resuming training * CAT-92 deal with file list ordering in the test * CAT-92 refactor and improve based on review * CAT-92 save potentially large checkpoint asynchronously * CAT-92 add workaround for py36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves CDB as checkpoints after certain steps during the unsupervised training. How many checkpoints are kept on the disk is also configurable.