Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply type checking to the whole medcat module #182

Merged
merged 21 commits into from
Jan 7, 2022
Merged

Apply type checking to the whole medcat module #182

merged 21 commits into from
Jan 7, 2022

Conversation

baixiac
Copy link
Member

@baixiac baixiac commented Dec 21, 2021

No description provided.

@baixiac
NO-TICKET add type hints to CAT and improve tests
e81f33b
@baixiac
CAT-86 add type hints to data_utils
b70a1fa
@baixiac
CAT-86 make medcat core pass type checks
516c0d3
@baixiac
CAT-86 add type check to the CI pipeline
a640300
@baixiac
CAT-86 rebase master and resolve conflicts
9dc5bc4
@baixiac
CAT-86 fix linting issues
eae4763
@baixiac
CAT-86 add the abstract tokenizer class for meta_cat
55600c9
@baixiac
CAT-86 get rid of circular imports
2ba2818
@baixiac
CAT-86 improve typing based on the review
87cf2a7
@baixiac
CAT-86 add type checks for medcat/*/*.py
04d1752
@baixiac
CAT-86 fix linting issues
541be2f
@baixiac
CAT-86 fix the prepare_name bug and refactor
ef19a2a
@baixiac
CAT-86 improve typing in meta_cat_tokenizers
53dd0a4
@baixiac
CAT-86 make all type checking pass
c0c1d37
@baixiac
CAT-86 rebase master
6a7ecc9
@baixiac
Merge branch 'master' of github.com:CogStack/MedCAT into type-hints-iii
0f6cbbc
@baixiac
CAT-99 apply type checking to the whole medcat module
9df9bb0
@baixiac
CAT-99 remove ignored
c9104a5
@baixiac
CAT-99 merge from master
5c1e740
@baixiac
CAT-99 make tests pass
e49c6fc
@baixiac
CAT-99 fix prepare_name call
e89e9df
w-is-h
w-is-h approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@w-is-h w-is-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@baixiac baixiac merged commit 67497d5 into master Jan 7, 2022
@baixiac baixiac deleted the type-hints-iii branch January 7, 2022 10:11
mart-r pushed a commit to mart-r/MedCAT that referenced this pull request Jun 14, 2023
@baixiac
Apply type checking to the whole medcat module (CogStack#182)
8c14f69 
* CAT-99 apply type checking to the whole medcat module

* CAT-99 fix prepare_name call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-is-h w-is-h w-is-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baixiac @w-is-h