Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8693v3tt6 SOMED opcs refset selection #402

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Feb 16, 2024

The OPCS4 refset ID in the current version is 1126441000000105 . However, in SNOMED2024 it seems to be 1382401000000109.

So this PR changes the behaviour of the snomed preprocessor.

It also adds a method to convert the ICD10/OPCS4 mappings to direct mapping.

And adds some tests as well.

@tomolopolis
Copy link
Member

Copy link
Collaborator

@antsh3k antsh3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

In the future, we should add deprecation warnings and limits to which versions of SNOMED CT we are compatible with.

@mart-r mart-r merged commit a3138a6 into master Feb 16, 2024
5 checks passed
mart-r added a commit that referenced this pull request Feb 28, 2024
* Cu 8693u6b4u tests continue on fail (#400)

* CU-8693u6b4u: Make sure failed/errored tests fail the main workflow

* CU-8693u6b4u: Attempt to fix deid multiprocessing, at least for GHA

* CU-8693u6b4u: Fix small docstring issue

* CU-8693v3tt6 SOMED opcs refset selection (#402)

* CU-8693v3tt6: Update refset ID for OPCS4 mappings in newer SNOMED releases

* CU-8693v3tt6: Add method to get direct refset mappings

* CU-8693v3tt6: Add tests to direct refset mappings method

* CU-8693v3tt6: Fix OPCS4 refset ID selection logic

* CU-8693v3tt6: Add test for OPCS4 refset ID selection

* CU-8693v6epd: Move typing imports away from pydantic (#403)

* CU-8693qx9yp Deid chunking - hugging face pipeline approach (#405)

* Pushing chunking update

* Update transformers_ner.py

* Pushing update to config

Added NER config in cat load function

* Update cat.py

* Updating chunking overlap

* CU-8693qx9yp: Add warning for deid multiprocessing with (potentially) non-functioning chunking window

* CU-8693qx9yp: Fix linting issue

---------

Co-authored-by: mart-r <mart.ratas@gmail.com>

---------

Co-authored-by: Shubham Agarwal <66172189+shubham-s-agarwal@users.noreply.github.com>
@mart-r mart-r deleted the CU-8693v3tt6-snomed-opcs-refset branch March 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants