CU-8694vbw6y k-fold stats Standard Deviation #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-8694vbw6y k-fold metrics - include std dev |
tomolopolis
approved these changes
Jul 10, 2024
|
|
||
| def _update_all_add(joined: List[Dict[str, int]], single: List[Dict[str, int]]) -> None: | ||
| def get_std(self): |
There was a problem hiding this comment.
Is this needed given this: https://docs.python.org/3.11/library/statistics.html#statistics.pstdev
you can specify mu=get_mean().
Also in 3.11, statistics.fmean supports a weigthing
There was a problem hiding this comment.
The current implementation expects to work for the weighted case (it's just that in some cases the weights are all equal (to 1)).
As far as I can tell, the other options do not (at least currently) support weighted means or standard deviations.
Plus, we'd need something that would support 3.8 through to 3.11.
mart-r
added a commit
that referenced
this pull request
Jul 18, 2024
* CU-8694vbw6y: Update k-fold metrics to allow including standard deviation in results * CU-8694vbw6y: Add tests for new parts of k-fold metrics (e.g standard deviation) * CU-8694vbw6y: Fix typing issues k-fold metrics and standard deviation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally add standard deviation to k-fold metrics output.
The PR simplifies the mean calculation to allow simpler standard deviation calculations as well.
PS:
Had some weird (at least to me) issues with
mypythat I didn't really understand.The details
Here's the errors it shows:
It's weird that it assumes the wrong type on lines 435 and 445 since the target is the same. If
mypyassumed reversed target types, it should work just fine.And really not sure about the
summethod expecting an iterable ofbools either.