Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug) fixes and improvements on clone agent command #154

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

fabclj
Copy link
Collaborator

@fabclj fabclj commented Feb 26, 2024

This PR include a workaround that fixes the rate limit errors when cloning a agent with high number of resources and consequent high number of API requests.
Updated the Readme file including the rate limit risks on large agents

@fabclj fabclj requested a review from lkolapp February 26, 2024 08:30
@fabclj fabclj marked this pull request as ready for review February 26, 2024 08:31
@XavierJordaMurria
Copy link
Collaborator

Should we do this for pulling the Lexicons too? I think we could also end up with an agent with a lot of lexicons, and then we would have this issue again.

@fabclj
Copy link
Collaborator Author

fabclj commented Feb 26, 2024

Should we do this for pulling the Lexicons too? I think we could also end up with an agent with a lot of lexicons, and then we would have this issue again.

Right, it make sense to handle here also this case. I will prepare something.

Edit: looking on lexicon file, I see that we are currently awaiting for lexicons one by one. We never implemented a Promise.all solution. So we cannot run into the issue we had in pullFlow iteration, but we could have the problem about a very slow process in case of agent with large number of lexicons. I suggest to implement anyway a chunked promise.all solution.

for (let lexicon of lexicons.items) {

@fabclj fabclj changed the title fix(bug) fixes on clone agent command and pullFlow logic fix(bug) fixes and improvements on clone agent command Feb 26, 2024
@fabclj fabclj merged commit 7d57a42 into develop Feb 26, 2024
4 checks passed
@XavierJordaMurria
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants