Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webchat.clearMessages() function #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbrau12s
Copy link

One of our customers requested this feature, would be nice if you could merge it! :)

@pedily
Copy link
Member

pedily commented Jan 28, 2022

Hi @mbrau12s,
Thank you for actively contributing to the WebchatWidget!

I'm happy to add this functionality, but we'll need to do the following additional things first:

  • the "API Documentation" should be updated as well featuring a small explanation and a code example (docs/webchat-api.md)
  • to avoid breaking this, we should add automated tests which check that
    • the history is cleared when the webchat is open
    • that the "unread message badge" and "unread message preview" are cleared when the webchat is not open and has unread messages
    • the history stays cleared after the page reloads using the same userId and sessionId

If you want, I can help you with the automated tests. Just let me know :)

@dheckl
Copy link

dheckl commented Sep 5, 2022

Is it possible to get the requirements from @pedily done and the PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants