Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix end of file offset in JvmLocalFileHeader when reading files with data descriptor #19

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Fix end of file offset in JvmLocalFileHeader when reading files with data descriptor #19

merged 4 commits into from
Jul 5, 2023

Conversation

NeRdTheNed
Copy link
Contributor

This only takes the offset into account, the data descriptor is not parsed.

@NeRdTheNed NeRdTheNed marked this pull request as ready for review July 4, 2023 06:06
@Col-E Col-E added bug Something isn't working enhancement New feature or request labels Jul 4, 2023
@Col-E
Copy link
Owner

Col-E commented Jul 4, 2023

I'd like to have a sample to test against. I don't know of any tools that make this data descriptor, and the other samples I made from a hex editor. Not the end of the world if we can't find something that does this.

@NeRdTheNed
Copy link
Contributor Author

NeRdTheNed commented Jul 4, 2023 •
edited
Loading

@Col-E Mod Menu is actually where I first noticed this, v7.1.0 has data descriptor sections for each local file header (as well as earlier versions).

@Col-E Col-E merged commit 4aeb2db into Col-E:master Jul 5, 2023
This was referenced Jul 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeRdTheNed @Col-E