Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add change password page and apply translation #72

Merged
merged 25 commits into from
Aug 7, 2024
Merged

Conversation

Colin-XKL
Copy link
Owner

@Colin-XKL Colin-XKL commented Aug 6, 2024

Summary by Sourcery

Add a 'Change Password' page and apply translations to the admin dashboard. Introduce a 'CraftFlowSelect' component and refactor user update logic to separate password updates from other user information updates. Update dependencies in pnpm-lock.yaml.

New Features:

  • Add a 'Change Password' page to the admin dashboard.
  • Introduce a new 'CraftFlowSelect' component for selecting craft flows.

Enhancements:

  • Apply translations to various UI elements in the admin dashboard, converting English text to Chinese.
  • Refactor user update logic to separate password updates from other user information updates.

Build:

  • Update dependencies in pnpm-lock.yaml, including pinia and vue-i18n.

Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new change password page and applies translations to various components. It also refactors the user update logic to separate password updates and adds a new ChangePassword function. Additionally, it updates the pinia and vue-i18n versions and replaces with a new component in multiple places.

File-Level Changes

Files Changes
web/admin/src/views/dashboard/craft_flow/craft_flow.vue
web/admin/src/views/dashboard/craft_atom/craft_atom.vue
web/admin/src/views/dashboard/custom_recipe/custom_recipe.vue
web/admin/src/views/dashboard/feed_viewer/feed_viewer.vue
web/admin/src/views/dashboard/llm_debug/ad-check-debug.vue
web/admin/src/views/dashboard/llm_debug/llm-debug.vue
web/admin/src/views/dashboard/llm_debug/llm-test.vue
web/admin/src/views/dashboard/feed_viewer/feed_view_container.vue
Translated static text to Chinese across multiple components.
internal/controller/user.go
internal/dao/user.go
Refactored user update logic to separate password update and added ChangePassword function.
web/admin/src/views/dashboard/feed_compare/feed_compare.vue
web/admin/src/views/dashboard/craft_flow/craft_flow.vue
Replaced with component.
web/admin/pnpm-lock.yaml Updated pinia and vue-i18n versions.
web/admin/src/router/routes/modules/dashboard.ts
internal/controller/auth.go
internal/router/registry.go
Fixed import paths and added new route for ChangePassword function.
web/admin/src/api/user.ts
web/admin/src/views/dashboard/admin/pass.vue
web/admin/src/router/routes/modules/admin.ts
Added new page and API for changing password.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Colin-XKL - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This is a large PR touching many areas of the codebase. In the future, consider breaking such changes into smaller, more focused PRs for easier review and reduced risk. Also, please remove commented-out code instead of leaving it in the codebase.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

internal/controller/user.go Show resolved Hide resolved
@Colin-XKL Colin-XKL merged commit 3c5d07d into main Aug 7, 2024
6 checks passed
@Colin-XKL Colin-XKL deleted the v2-rc branch August 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant