-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add change password page and apply translation #72
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new change password page and applies translations to various components. It also refactors the user update logic to separate password updates and adds a new ChangePassword function. Additionally, it updates the pinia and vue-i18n versions and replaces with a new component in multiple places. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Colin-XKL - I've reviewed your changes - here's some feedback:
Overall Comments:
- This is a large PR touching many areas of the codebase. In the future, consider breaking such changes into smaller, more focused PRs for easier review and reduced risk. Also, please remove commented-out code instead of leaving it in the codebase.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
Add a 'Change Password' page and apply translations to the admin dashboard. Introduce a 'CraftFlowSelect' component and refactor user update logic to separate password updates from other user information updates. Update dependencies in pnpm-lock.yaml.
New Features:
Enhancements:
Build: