Add test for CoolPreview formatter. #82
Conversation
| @@ -1,4 +1,4 @@ | |||
| <div> | |||
| <div class="cool-preview__wrapper"> | |||
There was a problem hiding this comment.
It's hard to target the preview wrapper, added class.
There was a problem hiding this comment.
Tbh I am not sure about these class names.
We have cool-preview__wrapper, cool-editor__dialog, cool-frame__preview.
But atm I can't think of something better, so let's review this later.
The main risk here is that people start using the class in their CSS, and then it becomes harder to change.
So we should review all the html before a stable release.
So, ok for now.
| $media->getName(), | ||
| $media->getName(), |
There was a problem hiding this comment.
The template is displaying first element duplicated on a multivalued field.
There was a problem hiding this comment.
I am not sure we should even test for cardinality > 1, as the whole system doesn't work but for the first element.
There was a problem hiding this comment.
For this, removed multivalued field configuration. Add isApplicable() and readme instruccions in another branch.
|
|
||
| $crawler = new Crawler((string) \Drupal::service('renderer')->renderRoot($build)); | ||
| $elements = $crawler->filter('div.cool-preview__wrapper'); | ||
| $this->assertCount(count($expected_medias), $elements); |
| $this->assertCount(1, $dialog); | ||
| $this->assertCount(1, $dialog->filter('iframe.cool-frame__preview')); | ||
| // Library for each file. | ||
| $this->assertEquals(['collabora_online/cool.previewer'], $build[$i]['#attached']['library']); |
There was a problem hiding this comment.
Uhm we shouldn't check this, this way... Doesn't it bubble up?
There was a problem hiding this comment.
Yes, it does. Added a check to see that the library is present or not.
| $media->getName(), | ||
| $media->getName(), |
There was a problem hiding this comment.
I am not sure we should even test for cardinality > 1, as the whole system doesn't work but for the first element.
AaronGilMartinez
force-pushed
the
test-field-formatter
branch
from
70c85de to
601e3e2
Compare
| @@ -1,4 +1,4 @@ | |||
| <div> | |||
| <div class="cool-preview__wrapper"> | |||
There was a problem hiding this comment.
Tbh I am not sure about these class names.
We have cool-preview__wrapper, cool-editor__dialog, cool-frame__preview.
But atm I can't think of something better, so let's review this later.
The main risk here is that people start using the class in their CSS, and then it becomes harder to change.
So we should review all the html before a stable release.
So, ok for now.
| protected static $modules = [ | ||
| 'collabora_online', | ||
| 'key', | ||
| 'media', | ||
| 'user', | ||
| 'field', | ||
| 'system', | ||
| 'file', | ||
| 'image', | ||
| 'entity_test', | ||
| ]; |
There was a problem hiding this comment.
No need to repeat modules from the parent class.
| protected static $modules = [ | |
| 'collabora_online', | |
| 'key', | |
| 'media', | |
| 'user', | |
| 'field', | |
| 'system', | |
| 'file', | |
| 'image', | |
| 'entity_test', | |
| ]; | |
| protected static $modules = [ | |
| 'entity_test', | |
| ]; |
|
|
||
| // Create test file. | ||
| file_put_contents('public://file-1.txt', $this->randomString()); | ||
| File::create(['uri' => 'public://test-1.txt'])->save(); |
There was a problem hiding this comment.
Any reason for the '-1' in the example file name?
There was a problem hiding this comment.
Leftover, changing the name.
AaronGilMartinez
force-pushed
the
test-field-formatter
branch
from
601e3e2 to
ae43924
Compare
AaronGilMartinez
force-pushed
the
test-field-formatter
branch
from
ae43924 to
74f3e69
Compare
No description provided.