Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet border design #7498

Closed
juliusknorr opened this issue Oct 20, 2023 · 3 comments
Closed

Spreadsheet border design #7498

juliusknorr opened this issue Oct 20, 2023 · 3 comments
Labels
bug Something isn't working calc Issues/Changes that affect calc specifically design duplicate This issue or pull request already exists

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Oct 20, 2023

Describe the Bug

Comparing spreadsheets with other solutions i noticed some small changes that could improve the overall look:

  • The border size of columns seem to be 2px while all other solutions as well as Libreoffice on the desktop uses 1px
Collabora Online Libreoffice Desktop Microsoft Excel
Screenshot 2023-10-20 at 12 21 57 Screenshot 2023-10-20 at 12 28 50 Screenshot 2023-10-20 at 12 22 00
  • The border color seems to be not consistent, i though I reported this already but cannot find the issue (maybe it was just during a call)
    • Most visible in dark mode, but also the case in light mode. Every nth row is slightly changed in color

Screenshot 2023-10-20 at 12 21 24

  • The focus outline seems to have a slight blur, compared to other solutions where it is full color with increased size
Collabora Online Libreoffice Desktop
Screenshot 2023-10-20 at 12 26 21 Screenshot 2023-10-20 at 12 26 44

cc @pedropintosilva @jancborchardt

@jancborchardt
Copy link

Agree with everything except the cell highlight color for LibreOffice Desktop is probably too light for accessibility, should probably be our color-primary-element?

@timur-g
Copy link
Contributor

timur-g commented Nov 1, 2023

If this was tested in Firefox, then there is a bug there from version 115, menitoned also in #7316. Bisected and reported.

@juliusknorr
Copy link
Member Author

You're right, sorry I somehow missed to test this in other browsers. Hoping for a quick upstream fix 🤞 Let me close this then as a duplicate of #7316

@juliusknorr juliusknorr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
@Tex2002ans Tex2002ans added calc Issues/Changes that affect calc specifically design duplicate This issue or pull request already exists and removed unconfirmed labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working calc Issues/Changes that affect calc specifically design duplicate This issue or pull request already exists
Projects
Archived in project
Development

No branches or pull requests

4 participants