Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calc: Grid lines render issue with firefox on linux #7316

Closed
soeffi opened this issue Sep 27, 2023 · 8 comments
Closed

Calc: Grid lines render issue with firefox on linux #7316

soeffi opened this issue Sep 27, 2023 · 8 comments
Assignees
Labels
23.05 24.04 bug Something isn't working calc Issues/Changes that affect calc specifically

Comments

@soeffi
Copy link

soeffi commented Sep 27, 2023

Describe the Bug

Not sure if this is actually a bug in Collabora, but I'd be glad if someone could help me out:

Using Code Calc (23.05.4.2, via docker, integrated in nextcloud) with firefox (118.0) on linux, grid lines are rendered as thick light grey lines, see screenshot below. Grid lines are distracting from actual contents, greatly limiting efficient use.

Interestingly, everything works fine with firefox on Windows and with Chromium on linux.

Steps to Reproduce

Open Collarbora Calc with firefox on linux.

Expected Behavior

Grid rendered with sharp lines as observed in other browsers.

Actual Behavior

Grid is rendered with muddy, thick lines

Screenshots

grafik

Desktop

(Please complete the following information)

  • OS: Ubuntu 22.04.3 LTS
  • Browser: Firefox
  • Version: 118.0
@timur-g
Copy link
Contributor

timur-g commented Sep 27, 2023

Really.. and it seem recent, I do not see it in ESR 102.15, but I see it in 117 (that is ESR 115).
image

@mmeeks
Copy link
Contributor

mmeeks commented Nov 1, 2023

@timur-g can you link the up-stream firefox ticket here too ? =) or didn't we get far with that ?

@timur-g
Copy link
Contributor

timur-g commented Nov 1, 2023

@mmeeks https://bugzilla.mozilla.org/show_bug.cgi?id=1857185

@mmeeks
Copy link
Contributor

mmeeks commented Nov 29, 2023

If the up-stream Mozilla "anti-aliasing" acceleration makes it impossible to draw accelerated lines with firefox - quite possibly we need to detect that browser and do pixel bashing instead to get the same result; hopefully only for firefox.

@Tex2002ans Tex2002ans added the calc Issues/Changes that affect calc specifically label Feb 5, 2024
@Tex2002ans
Copy link
Contributor

Looks like someone also posted a related issue on the Mozilla bugtracker:

Both that one+ours seems to have regressed on the same Firefox 115 issue 9 months ago:

@mmeeks
Copy link
Contributor

mmeeks commented Feb 6, 2024

Thanks - would be good to cross-link the tickets if not =)

@mmeeks
Copy link
Contributor

mmeeks commented Oct 25, 2024

@Cwiiis fairly annoying browser bug - would it be something that you could look at implementing a "draw horizontal or vertical hair-line" method that performs reasonably well in firefox ? and then using that - particularly for spreadsheet grid-lines (rendered in the browser), but I guess also all around the place where we use the canvas (?) =)

Alternatively - if it's easy to fix in firefox, we should do that I suppose but ... ;-> shaders + other nightmares probably make that not so easy. Thoughts ?

mmeeks added a commit that referenced this issue Nov 22, 2024
…refox.

Somewhat disappointing cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1857185

Interestingly dashed-hair-lines still seem to work nicely on large canvases.

cf. #7316

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I1371671e4ef8e8ca1e5f2790c3f0f2431bf9e2ba
mmeeks added a commit that referenced this issue Nov 23, 2024
…refox.

Somewhat disappointing cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1857185

Interestingly dashed-hair-lines still seem to work nicely on large canvases.

cf. #7316

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I1371671e4ef8e8ca1e5f2790c3f0f2431bf9e2ba
@mmeeks
Copy link
Contributor

mmeeks commented Nov 23, 2024

Should be fixed in the next release; thanks for reporting ! =)

@mmeeks mmeeks closed this as completed Nov 23, 2024
andreasma pushed a commit to freeonlineoffice/online that referenced this issue Nov 23, 2024
…refox.

Somewhat disappointing cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1857185

Interestingly dashed-hair-lines still seem to work nicely on large canvases.

cf. CollaboraOnline/online#7316

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I1371671e4ef8e8ca1e5f2790c3f0f2431bf9e2ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.05 24.04 bug Something isn't working calc Issues/Changes that affect calc specifically
Projects
Status: Done
Development

No branches or pull requests

5 participants