Private/timar/config #10587
Merged
Private/timar/config #10587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix we got, e.g. ./configure: line 19348: linux-gnu: command not found Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I99b02b677a46de6a62625627e25bcc940fae410e
coolwsd-welcome.xml was not added to the tar.gz distribution therefore in practice the <welcome> section was never added to coolwsd.xml in release builds of Collabora Online. The fix follows other examples, where the config fragment is in configure.ac, not in separate file. Also a little more explanation is added to the description of the setting. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: If30563ca515c9c9451e32d3baa75cf97c5888c52
- We got a query from a customer wrt. <home_mode> in coolwsd.xml. It is the best not to include this setting in COOL builds, because it is for CODE users. The condition in configure.ac is whether we define welcome URL. We define welcome URL for CODE builds only. (But it's a legacy that may be cleaned up in the future, because we do not use that welcome URL actually, not even in CODE. We replaced the remote welcome screen to internal welcome dialog long ago. We may find a better way to make disctinction in configure.ac between CODE and COOL builds.) - The description of the setting was vague, probably it's not a secret, what it does. - The feedback.show setting was unnecessary. It was never in coolwsd.xml. In COOL we don't have feedback URL, so feedback dialog is never displayed and there is no visible Send Feedback button (or menu item). In CODE home mode we suppress the feedback popup. By default we enable the feedback popup in CODE. Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I158aede7c64f88ac3add843ff7ae9cca8b38aa94
vmiklos
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup wrt. welcome and home_mode.