set 'aria-expanded' to dropdwon combobox #11056
Conversation
hcvcastro
commented
Jan 30, 2025
hcvcastro
commented
- browser: accessibility: set 'aria-expanded' to dropdown button
- browser: accessibility: set 'aria-expanded' to widget menu button
- browser: accessibility: fix close dropdown widget menu button
- browser: accessibility: fix no click, close dropdown button
- browser: accessibility: set 'aria-popup' to combobox
- browser: accessibility: set 'aria-expanded' to combobox
- browser: accessibility: fix no click, close dropdown combobox
hcvcastro
force-pushed
the
pr/master/9F
branch
2 times, most recently
from
189dfcd to
836aa22
Compare
| JSDialog.AddOnClick(control.arrow, clickFunction); | ||
| builder.map.on('jsdialog', function (e) { |
There was a problem hiding this comment.
This code is duplicated, also best to not put many places for processing the message queue as it might later cause hard to find bugs.
It goes: socket -> JSDialogMessageRouter -> JSDialog component and only the "component" should execute any operations, calling some widget actions if needed.
Possible solution:
- please put in the widget's root (
control.container) function:onDropdownClose - Dropdown widget has already information about widget from which it was created (see
JSDialog.OpenDropdown(dropdownId, control.container <---) - Dropdown when closing, can call the
onDropdownCloseif exists
There was a problem hiding this comment.
Interesting your suggestion, I have traced events when dropdown is closed, which exists JSDialog.CloseDropdown and 'clickfunction' callbacks, I did not want to do invasive changes. Well let's try it.
| @@ -316,5 +320,13 @@ JSDialog.combobox = function (parentContainer, data, builder) { | |||
| content.value = text; | |||
| }; | |||
|
|
|||
| builder.map.on('jsdialog', function (e) { | |||
There was a problem hiding this comment.
this is duplication I'm talking about
| @@ -145,6 +145,7 @@ L.Control.JSDialog = L.Control.extend({ | |||
| console.warn('closePopover: no builder'); | |||
| } | |||
| else { | |||
| JSDialog.CloseDropdown(id, true); | |||
There was a problem hiding this comment.
not sure if it is needed, how does the call stack look like for this bug?
There was a problem hiding this comment.
(anonymous) (Widget.Combobox.js:327)
fire (Events.js:146)
JSDialog.CloseDropdown (Util.Dropdown.js:161)
closePopover (Control.JSDialog.js:148)
close (Control.JSDialog.js:86)
(anonymous) (Control.JSDialog.js:227)
hcvcastro
force-pushed
the
pr/master/9F
branch
7 times, most recently
from
5d7913f to
b233cf3
Compare
| @@ -145,6 +145,7 @@ L.Control.JSDialog = L.Control.extend({ | |||
| console.warn('closePopover: no builder'); | |||
| } | |||
| else { | |||
| JSDialog.CloseDropdown(id); | |||
There was a problem hiding this comment.
it calls: L.Map.THIS.fire('jsdialog' which probably will land here again.
easy to do a cycle, does it work? do we have cypress test for closing popup using that?
There was a problem hiding this comment.
No, I do not have evidence failing unit test
| @@ -154,5 +154,7 @@ if (activateValidation) { | |||
| window.app.file = new Proxy(window.app.file, validator); | |||
| } | |||
|
|
|||
| window.JSDialog = {}; // initialize jsdialog module | |||
| window.JSDialog = { | |||
| popupParent : null, | |||
There was a problem hiding this comment.
I would like to avoid globals, just keep it in the instance
| @@ -158,6 +161,11 @@ JSDialog.OpenDropdown = function (id, popupParent, entries, innerCallback, popup | |||
| }; | |||
|
|
|||
| JSDialog.CloseDropdown = function (id) { | |||
| if (this.popupParent) { | |||
There was a problem hiding this comment.
please avoid globals, we have menus with submenus :)
see calc -> conditional formatting
we need to save it inside instance
There was a problem hiding this comment.
Cascade popups?. Let me see what can I do
hcvcastro
force-pushed
the
pr/master/9F
branch
3 times, most recently
from
ea04f22 to
a9ea2ae
Compare
Even I have setup the attributes, the function are unreachable for desktop app. Change-Id: Ib9e8fbc4027c1f64f78406d9ffa088c04c64709c Signed-off-by: Henry Castro <hcastro@collabora.com>
If it is not clicked in the dropdown container there was no way to set attribute 'aria-expanded' to false Change-Id: I3a2f0db7b4516ed0a66b77326ab87c6a66339663 Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I782477b61bb2ad5732bc101306bf7a9d4dda4eb4 Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I45b4891a3b0bd52994cc264c46efe3241e150a7d Signed-off-by: Henry Castro <hcastro@collabora.com>
. Change-Id: I5a459164174ac4ba4cab42822772e3fb4a3dd711 Signed-off-by: Henry Castro <hcastro@collabora.com>
hcvcastro
force-pushed
the
pr/master/9F
branch
from
a9ea2ae to
a988854
Compare
