Don't show audit snackbar if all entries are all 'ok' state #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/audit_snackbar_only_if_notok
branch
3 times, most recently
from
7a7535e to
d583339
Compare
I see this on a local nextcloud where the audit dialog only has one entry which is "ok". Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I55f12125cbc0ca4c88c9220ed114d455e84639e0
caolanm
force-pushed
the
private/caolan/audit_snackbar_only_if_notok
branch
from
d583339 to
3cc24ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see this on a local nextcloud where the audit dialog only has one entry which is "ok".
Change-Id: I55f12125cbc0ca4c88c9220ed114d455e84639e0
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay