Include global.js in iOS app #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Luby <guibomacdev@gmail.com> Change-Id: I32a0c8cb76c824e8bf53ccdff89145caf351564d
6 tasks
Minion3665
approved these changes
Jul 31, 2024
Minion3665
added a commit
that referenced
this pull request
Jul 31, 2024
Commit 8f0f931 from #9442 broke both mobile apps in several ways... In addition to the fixes which android needed (see #9669), there were 2 things broken in the iOS app only. Here they are: - global.js wasn't included in the app resources (fixed by Patrick Luby in #9673) - A garbled m4 macro caused some css to fail in loading, and -- my current understanding is -- as we use things like the page height in rendering this caused us to have severe issues when running our JavaScript. That's fixed in this commit
Minion3665
added a commit
that referenced
this pull request
Jul 31, 2024
Commit 8f0f931 from #9442 broke both mobile apps in several ways... In addition to the fixes which android needed (see #9669), there were 2 things broken in the iOS app only. Here they are: - global.js wasn't included in the app resources (fixed by Patrick Luby in #9673) - A garbled m4 macro caused some css to fail in loading, and -- my current understanding is -- as we use things like the page height in rendering this caused us to have severe issues when running our JavaScript. That's fixed in this commit Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: Ie8580567bf8426fb9ae2f159acf5994238614795
Minion3665
added a commit
that referenced
this pull request
Jul 31, 2024
Commit 8f0f931 from #9442 broke both mobile apps in several ways... In addition to the fixes which android needed (see #9669), there were 2 things broken in the iOS app only. Here they are: - global.js wasn't included in the app resources (fixed by Patrick Luby in #9673) - A garbled m4 macro caused some css to fail in loading, and -- my current understanding is -- as we use things like the page height in rendering this caused us to have severe issues when running our JavaScript. That's fixed in this commit Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: Ie8580567bf8426fb9ae2f159acf5994238614795
Minion3665
added a commit
that referenced
this pull request
Aug 1, 2024
Commit 8f0f931 from #9442 broke both mobile apps in several ways... In addition to the fixes which android needed (see #9669), there were 2 things broken in the iOS app only. Here they are: - global.js wasn't included in the app resources (fixed by Patrick Luby in #9673) - A garbled m4 macro caused some css to fail in loading, and -- my current understanding is -- as we use things like the page height in rendering this caused us to have severe issues when running our JavaScript. That's fixed in this commit Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: Ie8580567bf8426fb9ae2f159acf5994238614795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.