feat(dsl): add Field.contains to enable the in operator
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolasfara your opinion is appreciated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 66.22% 66.16% -0.06%
==========================================
Files 26 26
Lines 601 603 +2
Branches 119 120 +1
==========================================
+ Hits 398 399 +1
- Misses 147 149 +2
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. |
nicolasfara
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Maybe a test for these utilities, as suggested by codecov, would be useful
DanySK
force-pushed
the
feat/contains
branch
9 times, most recently
from
ef90333 to
15c3a8c
Compare
DanySK
force-pushed
the
feat/contains
branch
12 times, most recently
from
dfe43e3 to
6b481cc
Compare
DanySK
force-pushed
the
feat/contains
branch
from
6b481cc to
d5a3e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.