This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Backend: Add sqlalchemy database models #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required db module to be split off to avoid ciruclar dependency.
What was he cooking
Left over from some route prototyping
|
you're using declarative base, but the imperative style mapping as defined in the docs https://docs.sqlalchemy.org/en/20/orm/mapping_styles.html#declarative-mapping if it works, I guess that's fine, but if our project wants to stick to being totally idiomatic we might want to use declarative in it's entirety. |
tbwrigh
suggested changes
Oct 25, 2023
|
will review after tyler's requested changes are resolved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required db module to be split off to avoid ciruclar dependency.