Improve .create ergonomics and add cancelation-handling #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freak4pc
force-pushed
the
create-improvements
branch
2 times, most recently
from
9a782f2 to
e320613
Compare
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 96.72% 96.94% +0.22%
==========================================
Files 34 34
Lines 1617 1638 +21
==========================================
+ Hits 1564 1588 +24
+ Misses 53 50 -3
Continue to review full report at Codecov.
|
freak4pc
force-pushed
the
create-improvements
branch
2 times, most recently
from
f376d67 to
daa932f
Compare
freak4pc
force-pushed
the
create-improvements
branch
from
daa932f to
6a87026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two improvements to
AnyPublisher.create:Instead of providing a raw closure, provides a subscriber-like argument with the familiar event-sending syntax of
send(_:),send(completion:).Allow providing a
Cancelable-conforming object as the return of that closure, which is useful to provide cleanup-logic to your custom publisher.Thanks to @mbrandonw for the great ideas and feedback 🥇🥳