[Refactor] Change to an event-driven radio system.

[Bubbus]

Pull Request Description

When merged this pull request will:

• Move to a more expressive radio config system.
• Make radio assignment more reliable.
• Allow SLs to push radio channels to subordinates.
• Add a nicer radio list in the map screen.
• Made creating multi-language roles easier.

Release Notes

A new radio system has been added which should make it easier and quicker to set up radios for missions. For more information, check the new acre_radio_configuration.sqf file in the configuration folder.

In addition, squad leaders can now manage the radio channels for the whole group and automatically push the radio channels onto their squad members - this should allow SLs to solve radio issues without having to ask everyone what net they're on.

Finally, a new radio list has been added which should make it easier to see radio information, and hide it away when not needed.

IMPORTANT

• Testing has been completed as neccessary, depending on the nature & impact of the changes.
• The Release Notes section below must be filled out appropriately to explain the changes made in this PR. This section will be used in Framework Changelogs.
• If the contribution affects the wiki, please include your changes in this pull request so the wiki is consistently updated.
• Contribution Guidelines are read, understood and applied.
• Title of this PR uses our standard template [Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.

Resolves #133

[Cre8or]

I see you've separated chunks of code into different files to later join them via includes - presumably to interface with the configuration file. However, imo this is done at the expense of readability: here you're declaring private variables without assigning them to anything or giving them a default value. If I later want to figure out where a variable comes from, I'd have to trace it here throughout the includes, which isn't ideal (especially with how small these files are).

I'd suggest merging the pre/post configuration snippets into the radio component, leaving only the include for the configuration file (so as to not expose component code to the user).

[Bubbus]

The config files are intended for user readability first - it sucks more as a developer but if it's more readable to MMs then it's the right way imo. That said, I'll collapse this whole deal down a bit because yeah it's a bit extra rn.

[Cre8or]

Refer to my comment about merging the pre/post files into here.

[Cre8or]

As discussed, I'd modify the ACRE override to use two distinct functions: your override, and the original function (compiled in the traditional way in CfgFunctions. but using a soft-dependency). The functions config would then become

#if __has_include("\idi\acre\addons\main\stringtable.xml")
    class acre_ace_interact
    {
        class overrides
        {
            file = "components\radio\acre";
            class radioListChildrenActions{};
            class radioListChildrenActions_original
            {
                file = "idi\acre\addons\ace_interact\fnc_radioListChildrenActions.sqf";
            };
        }
    }
#endif

Then we can omit lines 5-12 of your override:

if (isNil "f_var_originalFunction_addRadioActionsToClass") then
{
    // Why isn't this easier to do in SQF?  Why does it have to be so brittle?  thanks lads
    f_var_originalFunction_addRadioActionsToClass = compile preprocessFileLineNumbers "idi\acre\addons\ace_interact\fnc_radioListChildrenActions.sqf";
};


private _children = _this call f_var_originalFunction_addRadioActionsToClass;

and just do:

private _children = _this call acre_ace_interact_fnc_radioListChildrenActions_original;

[Cre8or]

Everything's resolved as far as I can see.

🚢

[Cre8or]

That function is now gone - good catch.