Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] - Zeus UI initialisation & Godmode #180

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[Improve] - Zeus UI initialisation & Godmode #180

merged 2 commits into from
Aug 14, 2023

Conversation

Cre8or
Copy link
Collaborator

@Cre8or Cre8or commented Aug 13, 2023

Pull Request Description

When merged this pull request will:

  • fix the custom Zeus UI not opening on the first use of the curator screen
  • fix godmode only being applied once on initialisation (rather than everytime the curator display is opened)
  • clean up various code areas (remove redundant Zeus UI component initialisation, add a safeguard for script spawning, remove obsolete comments)

NOTE: As per the checkboxes below, please also review the edited wiki page concerning Zeus.

Release Notes

  • The Zeus UI now properly shows everytime the Curator screen is opened (previously it didn't show on the first use)
  • Zeus God-mode now gets [re]applied everytime the Curator screen is opened (previously only on the first use)

IMPORTANT

  • Testing has been completed as neccessary, depending on the nature & impact of the changes.
  • The Release Notes section below must be filled out appropriately to explain the changes made in this PR. This section will be used in Framework Changelogs.
  • If the contribution affects the wiki, please include your changes in this pull request so the wiki is consistently updated.
  • Contribution Guidelines are read, understood and applied.
  • Title of this PR uses our standard template [Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.

Cre8or added 2 commits August 13, 2023 20:10
@Cre8or
3DEN function recompiling
8ad86cb 
Relaxed function recompiling restrictions to be enabled for server machines in 3DEN mutliplayer
@Cre8or
Godmode, QoL improvements, cleanup
17e139c 
- Fixed godmode only being applied once on initialisation (rather than everytime the curator display is opened)
- Moved initialisation code into fn_openZeus (replacing the now-redundant init loop polling curator display availability)
- Fixed custom Zeus UI not opening on the first use of the curator screen
- Added safeguard to giveUnitGodMode to ensure only one instance of the heal loop can run
@Cre8or Cre8or added the enhancement New feature or request label Aug 13, 2023
@Cre8or Cre8or self-assigned this Aug 13, 2023
@Cre8or Cre8or added this to the 1.7.0 milestone Aug 13, 2023
dgibso29
dgibso29 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@dgibso29 dgibso29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@Cre8or Cre8or merged commit 300b82e into develop Aug 14, 2023
@Cre8or Cre8or deleted the bugfix/zeus_ui-init-and-godmode branch August 15, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgibso29 dgibso29 dgibso29 approved these changes

@Bubbus Bubbus Awaiting requested review from Bubbus

@Joecuronium Joecuronium Awaiting requested review from Joecuronium

Assignees

@Cre8or Cre8or

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Cre8or @dgibso29