[Fix] - Compatibility with ACE 3.16 medical system #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored internal functions to be compatible the new medical variables used by ACE - Merged wounds healing code for critical bleeding from immersiveRevive into healWounds, and added an optional third parameter - Modified EQUALS macro to work with any variable type (not just objects)
- Fixed body part hitpoints not always being decreased with each wound healed (this made it impossible to fix weapon sway)
Cre8or
added
bug
Bubbus
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When merged this pull request will:
Update the framework's medical functions to be compatible with the changes to the ACE medical system introduced in ACE 3.16. This fixes various game-breaking issues resulting from using custom Zen modules on players (such as immersive revive, or wounds healing), which were caused by overwriting internal ACE data with incorrect data types.
Additionally, as a minor QoL change,
healWoundsnow assigns a score to each wound (stronger bleeding increases the score). It then heals wounds in decreasing score order - effectively prioritising injuries like large avulsions or velocity wounds over small bruises.Fixes #191.
Release Notes
Fixed compatibility with the ACE medical system changes introduced in v3.16.
IMPORTANT
[Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.