State machine #29
Merged
State machine #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the dot graph visualization so that properly labels state transitions now.
|
@sdandam I'd suggest pulling this branch down to your local machine and running the tests to get a feel for what this is doing. It also might be helpful to take the digraph and print it as a svg and check what transitions are happening. I don't think this is perfect yet but it's working decently well at this point that I want to start the review process. |
resolves #13
cholcombe973
force-pushed
the
state-machine
branch
from
3e7ac97
to
3f46318
Compare
|
Well this is a bummer. I ran into a cargo bug: rust-lang/cargo#4866 and it'll require us staying on nightly until it gets resolved. Not sure what else we can do it about it. I tried various things and nothing helps with getting this to compile on stable. |
Since the tests run in parallel by default I had to introduce a bunch of random variables and a mutex to make sure the tests weren't all writing to the same loopback backing file or grabbing the same loopback device from the system.
|
Awesome to see this |
sdandam
approved these changes
Aug 24, 2018
|
No problem. We've got a lot more testing to do before this makes it into production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drastically changes how test_disk functions and changes it over to using a state machine. The code will print out a digraph when tests are run so that the logic tree can be visualized.