Make Dns cross-platform, add reverse methods
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Oct 3, 2021
| } | ||
| /** Reverses the supplied address to a hostname using the platform DNS resolver. | ||
| * | ||
| * If the address cannot be reversed, the effect fails with an `UnknownHostException`. |
There was a problem hiding this comment.
I wasn't sure about this since its a slight abuse, but I don't see why UnknownHostException couldn't apply here as well.
For precedence, Node.js returns the same ENOTFOUND error for both resolve and reverse.
There was a problem hiding this comment.
Btw, JVM instead of returning an error for reverse just returns the IP address as a String ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cats-effect-kernelas both a JVM/JS dependency (cats-effectproper was previously a JVM dep)Dnsa sealed trait (assume this is ok?) and addsreverse,reverseOption, andreverseAllmethodsDnsfor Node.js (as long as browsers don't useDnsthey won't have problems)DnsTestFor context see http4s/http4s#5316 (comment)