Handle ASCII-encoded segmentation UPIDs correctly #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@sbowman Can you do a quick review of my changes... and sign the CLA so I can eventually merge this? I've modified your approach and changed it such that the models always use UTF8 but converts from Latin1 on decode and back on encode. This resolves a number of issues that your original fix didn't address around XML/JSON representation and lossless decoding and encoding. Thanks. |
sbowman
reviewed
Aug 1, 2023
|
Made changes per your feedback. If theres nothing else I'll merge it in tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.