fix: array params not being built correctly #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All URI parameters should be one name and one value pair, but their can be multiple parameters with the same name. We utilize this behavior for array values and add a name and value pair for each element in the array. For example 'statuses[]': ["in progress", "completed"] will become statuses%5B%5D=in+progress&statuses%5B%5D=completed FIXES: #21
As the method does not use 'this' it can be made into a static one.
- update method call to static version. - update description to specify only buildSearchParams is being tested in this block.
ComfortablyCoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All URI parameters should be one name and one value pair, but their can be multiple parameters with the same name.
buildSearchParamsnow utilizes this behavior for array values and add a name and value pair for each element in the array.For example
will now become
Fixes #21.