Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buildParams) array values without [] suffixed keys are not transformed to LHS format #39

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

Edsol
Copy link
Contributor

@Edsol Edsol commented Feb 10, 2024

the original code needed this structure (key as a string with square brackets):

{
    "assignees[]": [
        assignId
    ]
};

to make the call correctly as https://api.clickup.com/api/v2/team/{team_Id}/task?assignees[]=XXXX.

I refactored the function to be able to use the json structure correctly, like:

{
    assignees: [
        assignId
    ]
};

@Edsol Edsol changed the title Missing slash in delete function Fix and refactoring buildSearchParams Feb 10, 2024
@Edsol Edsol changed the title Fix and refactoring buildSearchParams Fix and refactoring buildSearchParams function Feb 10, 2024
@ComfortablyCoding ComfortablyCoding self-assigned this Feb 14, 2024
@ComfortablyCoding ComfortablyCoding added the bug Something isn't working label Feb 14, 2024
Copy link
Owner

@ComfortablyCoding ComfortablyCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@ComfortablyCoding ComfortablyCoding merged commit 4bd13ed into ComfortablyCoding:master Feb 14, 2024
1 check passed
@ComfortablyCoding ComfortablyCoding changed the title Fix and refactoring buildSearchParams function fix(buildParams) array values without [] suffixed keys are not transformed to LHS format Feb 14, 2024
@ComfortablyCoding ComfortablyCoding changed the title fix(buildParams) array values without [] suffixed keys are not transformed to LHS format fix(buildParams) array values without [] suffixed keys are not transformed to LHS format Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants