add check for the format arg type in VideoFromComponents.save_to function#11046
Merged
Kosinkadink merged 2 commits intoComfy-Org:masterfrom Dec 2, 2025
Merged
add check for the format arg type in VideoFromComponents.save_to function#11046Kosinkadink merged 2 commits intoComfy-Org:masterfrom
Kosinkadink merged 2 commits intoComfy-Org:masterfrom
Conversation
8 tasks
Contributor
Author
|
+label: Core |
bigcat88
changed the title
Kosinkadink
approved these changes
Dec 2, 2025
comfyanonymous
pushed a commit
that referenced
this pull request
Dec 3, 2025
…tion (#11046) * add check for the format var type in VideoFromComponents.save_to function * convert "format" to VideoContainer enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11044
Although the argument declaration states that only
VideoContainertype is accepted there, many custom nodes pass a string there.strtoVideoContainertype before callingvideo.save_toinSaveVideonode - to be a correct example for community.