Skip to content

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Apr 18, 2025

Resolves comfyanonymous/ComfyUI#7654
Resolves #3498

This PR uses guarded version of generateUUID for insecure context usage. Issue originally introduced in #3407

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Apr 18, 2025
@huchenlei huchenlei requested a review from a team as a code owner April 18, 2025 15:42
@huchenlei huchenlei merged commit 5d58457 into main Apr 18, 2025
7 of 8 checks passed
@huchenlei huchenlei deleted the fix_uuid branch April 18, 2025 15:43
@huchenlei huchenlei mentioned this pull request Apr 18, 2025
huchenlei pushed a commit to comfyanonymous/ComfyUI that referenced this pull request Apr 18, 2025
@webfiltered
Copy link
Contributor

Just noting: the impl. in litegraph (createUuidv4) works slightly differently; it falls back to crypto.getRandomValues rather than Math.random. This is not likely to cause issues.

huchenlei pushed a commit to comfyanonymous/ComfyUI that referenced this pull request Apr 18, 2025
mcmonkey4eva pushed a commit to Comfy-Org/ComfyUI-Mirror that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot "Save As" existing workflow as new workflow [Bug]: useErrorHandling.ts:8 TypeError: crypto.randomUUID is not a function

3 participants