[backport rh-test] [bugfix] use raw template ID for workflow_name in telemetry tracking #6324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6320) ## Summary Fixes `trackTemplate` calls to use raw template ID instead of translated workflow name for analytics tracking. ## Problem When users load templates with non-English locale, the `workflow_name` field was being tracked in their language (e.g., "默认工作流" for Chinese users) instead of English. This makes statistical analysis difficult. ## Changes - Updated both `trackTemplate` calls in `useTemplateWorkflows.ts` to use raw `id` instead of translated `workflowName` - The translated name is still used for display purposes in `loadGraphData` **Before:** ```typescript useTelemetry()?.trackTemplate({ workflow_name: workflowName, // Could be "默认工作流" template_source: sourceModule }) ``` **After:** ```typescript useTelemetry()?.trackTemplate({ workflow_name: id, // Always "default" template_source: sourceModule }) ``` ## Testing - [x] Type checking passes - [x] Verified translated names still used for display ## Related Part of comprehensive i18n audit for telemetry tracking. Related to template metadata English tracking in PR #6304. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6320-bugfix-use-raw-template-ID-for-workflow_name-in-telemetry-tracking-2996d73d365081d8aef3fa2529a10247) by [Unito](https://www.unito.io)
comfy-pr-bot
requested review from
Myestery,
christian-byrne and
comfyui-wiki
as code owners
2 tasks
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results🕵🏻 No test results found ⏰ Completed at: 10/27/2025, 05:08:59 AM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6320 to
rh-testAutomatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito