-
Notifications
You must be signed in to change notification settings - Fork 461
[fix] Re-encode cloud-subscription video to VP9 for Safari compatibility #7006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The original video was encoded with AV1 codec which Safari does not support, causing "Plug-in handled load" errors. Re-encoded to VP9 which is supported across all major browsers including Safari 14.1+.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/27/2025, 09:38:05 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/27/2025, 09:47:13 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 949 kB (baseline 949 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 139 kB (baseline 139 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 BBundles that do not match a named category
|
christian-byrne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
…ity (#7006) The original video was encoded with AV1 codec which Safari does not support, causing "Plug-in handled load" errors. Re-encoded to VP9 which is supported across all major browsers including Safari 14.1+. Summary - Re-encode cloud-subscription.webm from AV1 to VP9 codec for Safari browser compatibility Problem Safari does not support AV1 codec in webm containers, causing the cloud subscription video to fail with "Plug-in handled load" error. Solution Re-encoded the video using VP9 codec (libvpx-vp9) which is supported by all major browsers including Safari 14.1+. Test plan - Verify video plays correctly in Safari - Verify video plays correctly in Chrome/Firefox/Edge [cloud-subscription.webm](https://github.com/user-attachments/assets/ab2dcaa1-f3b3-47c9-84d0-9fc8ea8c6f17) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7006-fix-Re-encode-cloud-subscription-video-to-VP9-for-Safari-compatibility-2b86d73d365081ad9262f97fc1ebb5ee) by [Unito](https://www.unito.io)
… for Safari compatibility (#7012) Backport of #7006 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7012-backport-cloud-1-33-fix-Re-encode-cloud-subscription-video-to-VP9-for-Safari-compatib-2b86d73d365081a0be8ac57b8afce8a8) by [Unito](https://www.unito.io) Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
The original video was encoded with AV1 codec which Safari does not
support, causing "Plug-in handled load" errors. Re-encoded to VP9
which is supported across all major browsers including Safari 14.1+.
Summary
Problem
Safari does not support AV1 codec in webm containers, causing the cloud subscription video to
fail with "Plug-in handled load" error.
Solution
Re-encoded the video using VP9 codec (libvpx-vp9) which is supported by all major browsers
including Safari 14.1+.
Test plan
cloud-subscription.webm
┆Issue is synchronized with this Notion page by Unito