mark vue nodes menu toggle with beta tag #7047
Conversation
christian-byrne
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:XS
christian-byrne
added
needs-backport
📝 WalkthroughWalkthroughThese changes add a visual Beta badge to the nodes-2.0-toggle menu item in the sidebar and introduce a corresponding English localization string for the badge label. Changes
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/30/2025, 01:22:49 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/30/2025, 01:31:47 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 949 kB (baseline 949 kB) • 🔴 +309 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 17 added / 17 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/sidebar/ComfyMenuButton.vue(2 hunks)src/locales/en/main.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (15)
**/*.vue
📄 CodeRabbit inference engine (.cursorrules)
**/*.vue: Use setup() function for component logic in Vue 3 Composition API
Utilize ref and reactive for reactive state in Vue 3
Implement computed properties with computed() function
Use watch and watchEffect for side effects in Vue 3
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection in Vue 3
Use Vue 3.5 style of default prop declaration with defineProps()
Organize Vue components in <script> <style> order
Use Tailwind CSS for styling Vue components
Implement responsive design with Tailwind CSS
Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectively
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components in Vue 3
Follow Vue 3 style guide and naming conventions
Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Never use
:class="[]"to merge class names - always useimport { cn } from '@/utils/tailwindUtil'for class merging in Vue templates
**/*.vue: Use TypeScript with Vue 3 Single File Components (.vuefiles)
Name Vue components in PascalCase (e.g.,MenuHamburger.vue)Files:
src/components/sidebar/ComfyMenuButton.vue**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.jsonFiles:
src/components/sidebar/ComfyMenuButton.vue**/*.{ts,tsx,js,vue}
📄 CodeRabbit inference engine (.cursorrules)
Implement proper error handling in components and services
**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in.prettierrc
Organize imports by sorting and grouping by plugin, and runpnpm formatbefore committingFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventionsFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonFiles:
src/components/sidebar/ComfyMenuButton.vue**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
Use camelCase for variable and setting names in TypeScript/Vue files
Files:
src/components/sidebar/ComfyMenuButton.vue**/*.{vue,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
dark:ordark-theme:Tailwind variants - instead use semantic values fromstyle.csstheme, e.g.bg-node-component-surfaceFiles:
src/components/sidebar/ComfyMenuButton.vue**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,vue}: Useconst settingStore = useSettingStore()andsettingStore.get('Comfy.SomeSetting')to retrieve settings in TypeScript/Vue files
Useawait settingStore.set('Comfy.SomeSetting', newValue)to update settings in TypeScript/Vue files
Check server capabilities usingapi.serverSupportsFeature('feature_name')before using enhanced features
Useapi.getServerFeature('config_name', defaultValue)to retrieve server feature configurationEnforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates
Files:
src/components/sidebar/ComfyMenuButton.vuesrc/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebaseFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/sidebar/ComfyMenuButton.vuesrc/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/sidebar/ComfyMenuButton.vuesrc/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.jsonFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system packageFiles:
src/components/sidebar/ComfyMenuButton.vuesrc/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI stringsFiles:
src/components/sidebar/ComfyMenuButton.vue🧠 Learnings (8)
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panelsApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitchApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Do not use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage). Use replacements: Select, Popover, DatePicker, ToggleSwitch, Drawer, AutoComplete, Tabs, Stepper, Message respectivelyApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with PopoverApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:46:52.279Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: .cursorrules:0-0 Timestamp: 2025-11-24T19:46:52.279Z Learning: Applies to **/*.vue : Never use deprecated PrimeVue components (Dropdown, OverlayPanel, Calendar, InputSwitch, Sidebar, Chips, TabMenu, Steps, InlineMessage)Applied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with DrawerApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with MessageApplied to files:
src/components/sidebar/ComfyMenuButton.vue📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR Repo: Comfy-Org/ComfyUI_frontend PR: 0 File: src/components/CLAUDE.md:0-0 Timestamp: 2025-11-24T19:47:45.616Z Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with SelectApplied to files:
src/components/sidebar/ComfyMenuButton.vue🪛 Biome (2.1.2)
src/locales/en/main.json
[error] 3-3: The key beta was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
🪛 ESLint
src/components/sidebar/ComfyMenuButton.vue
[error] 105-105: Unable to resolve path to module 'primevue/tag'.
(import-x/no-unresolved)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (1)
src/components/sidebar/ComfyMenuButton.vue (1)
105-105: I'll help you verify the import statement for the PrimeVue Tag component. Let me start by examining the file and checking if the import is actually used.
<function_calls>
#!/bin/bashFirst, let's check the file size and read the relevant section
wc -l src/components/sidebar/ComfyMenuButton.vue
echo "---"Read the file to understand the context and check if Tag is used
cat -n src/components/sidebar/ComfyMenuButton.vue | head -150
</function_calls>Requesting shell capability to examine the file structure and verify Tag usage.
| @click.stop="handleNodes2ToggleClick" | ||
| > | ||
| <span class="p-menubar-item-label text-nowrap">{{ item.label }}</span> | ||
| <Tag severity="info" class="ml-2 text-xs">{{ $t('g.beta') }}</Tag> |
There was a problem hiding this comment.
Translation key blocked by duplicate in main.json.
The $t('g.beta') will resolve to "BETA" instead of "Beta" due to the duplicate key issue flagged in src/locales/en/main.json line 3. Once that's fixed by using a distinct key (e.g., g.betaTag), update this reference accordingly.
🤖 Prompt for AI Agents
In src/components/sidebar/ComfyMenuButton.vue around line 76, the template
currently uses $t('g.beta') which resolves to the wrong string because of a
duplicate key in src/locales/en/main.json; change the translation reference to
the new distinct key (for example $t('g.betaTag')) to match the updated locales
file, and verify the locales file contains the new key/value ("Beta") so the
component shows the corrected capitalisation.
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "g": { | |||
| "beta": "Beta", | |||
There was a problem hiding this comment.
Critical: Duplicate key will cause incorrect value.
This adds a "beta" key, but line 253 already defines "beta": "BETA" in the same "g" object. JSON objects cannot have duplicate keys—only the last definition (line 253: "BETA") will be used. This means the Beta tag in ComfyMenuButton.vue will display "BETA" instead of the intended "Beta".
Solution: Use a distinct key name:
- "beta": "Beta",
+ "betaTag": "Beta",Then update ComfyMenuButton.vue line 76:
- <Tag severity="info" class="ml-2 text-xs">{{ $t('g.beta') }}</Tag>
+ <Tag severity="info" class="ml-2 text-xs">{{ $t('g.betaTag') }}</Tag>Alternatively, if line 253's "beta": "BETA" is unused, remove it and keep this new entry.
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (2.1.2)
[error] 3-3: The key beta was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
In src/locales/en/main.json around line 3 (and referencing the duplicate at line
253), you added a "beta" key that duplicates an existing "beta": "BETA" entry —
JSON will keep only the last one, causing the wrong text to display. Fix by
renaming this new key to a unique name (e.g., "betaLabel") or removing the other
duplicate at line 253; if you rename the key, update ComfyMenuButton.vue (around
line 76) to use the new key name so the intended "Beta" string is used.
## Summary Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta. <img width="752" height="918" alt="Selection_2477" src="https://github.com/user-attachments/assets/cf341b2b-1af6-4259-8449-bf157989b7b3" /> <img width="433" height="880" alt="Selection_2476" src="https://github.com/user-attachments/assets/a0f658bf-1904-4d79-9ca7-c81c458adc54" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7047-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d3650815e8a9aceaa9250c02e) by [Unito](https://www.unito.io)
## Summary Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta. <img width="752" height="918" alt="Selection_2477" src="https://github.com/user-attachments/assets/cf341b2b-1af6-4259-8449-bf157989b7b3" /> <img width="433" height="880" alt="Selection_2476" src="https://github.com/user-attachments/assets/a0f658bf-1904-4d79-9ca7-c81c458adc54" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7047-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d3650815e8a9aceaa9250c02e) by [Unito](https://www.unito.io)
## Summary Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta. <img width="752" height="918" alt="Selection_2477" src="https://github.com/user-attachments/assets/cf341b2b-1af6-4259-8449-bf157989b7b3" /> <img width="433" height="880" alt="Selection_2476" src="https://github.com/user-attachments/assets/a0f658bf-1904-4d79-9ca7-c81c458adc54" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7047-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d3650815e8a9aceaa9250c02e) by [Unito](https://www.unito.io)
## Summary Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta. <img width="752" height="918" alt="Selection_2477" src="https://github.com/user-attachments/assets/cf341b2b-1af6-4259-8449-bf157989b7b3" /> <img width="433" height="880" alt="Selection_2476" src="https://github.com/user-attachments/assets/a0f658bf-1904-4d79-9ca7-c81c458adc54" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7047-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d3650815e8a9aceaa9250c02e) by [Unito](https://www.unito.io)
|
@christian-byrne Successfully backported to #7049 |
|
@christian-byrne Successfully backported to #7050 |
|
@christian-byrne Successfully backported to #7051 |
|
@christian-byrne Successfully backported to #7052 |
github-actions
bot
removed
the
needs-backport
Backport of #7047 to `core/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7049-backport-core-1-32-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d36508101bcaee0e236aac373) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #7047 to `cloud/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7050-backport-cloud-1-32-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d365081658342f18759c69a32) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #7047 to `core/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7051-backport-core-1-33-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d365081b09428d6f0bb21dc67) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #7047 to `cloud/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7052-backport-cloud-1-33-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d365081da9bb6cb1859c7bf5a) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
## Summary Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta. <img width="752" height="918" alt="Selection_2477" src="https://github.com/user-attachments/assets/cf341b2b-1af6-4259-8449-bf157989b7b3" /> <img width="433" height="880" alt="Selection_2476" src="https://github.com/user-attachments/assets/a0f658bf-1904-4d79-9ca7-c81c458adc54" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7047-mark-vue-nodes-menu-toggle-with-beta-tag-2bb6d73d3650815e8a9aceaa9250c02e) by [Unito](https://www.unito.io)
Summary
Adds a "Beta" tag next to the Nodes 2.0 menu item toggle to better indicate to users, especially new users, that the feature is in beta.
┆Issue is synchronized with this Notion page by Unito