Fix workflow loading from PNG images with both workflow and parameter… #7154

r-vage · 2025-12-04T06:28:21Z

…s metadata

Reorder handleFile() to check workflow before parameters
Add validation to prevent JSON parse errors from crashing imports
Fix loadGraphData() to use explicit type validation instead of falsy check
Ensures ComfyUI-generated PNGs with both metadata types load the workflow, not parameters

Fixes issue where large workflows (e.g., 634 nodes) were replaced with basic A1111 format when importing PNG files.

Summary

Fixed workflow loading from PNG images to prioritize workflow metadata over parameters, preventing large workflows from being replaced with basic A1111 format.

Changes

What: Reordered handleFile() to check workflow before parameters, added JSON parse error handling and validation, fixed loadGraphData() to use explicit type checking instead of falsy check
Dependencies: None

Review Focus

The key issue was in handleFile() where parameters were checked before workflow, causing ComfyUI-generated PNGs (which contain both workflow and parameters metadata) to incorrectly import as A1111 format. The fix ensures:

Workflow is always checked first and validated properly
Parameters are only used as a fallback when no workflow exists
Invalid/malformed workflow data doesn't crash the import process

Additionally, loadGraphData() was using a falsy check (if (!graphData)) which could incorrectly replace valid but falsy values. Now uses explicit type validation.

Tested with real-world PNG containing 634-node workflow (780KB) + parameters (1KB) - now correctly loads the workflow instead of discarding it.

Screenshots (if applicable)

N/A - Backend logic fix, no UI changes

Fixes #6633

┆Issue is synchronized with this Notion page by Unito

…s metadata - Reorder handleFile() to check workflow before parameters - Add validation to prevent JSON parse errors from crashing imports - Fix loadGraphData() to use explicit type validation instead of falsy check - Ensures ComfyUI-generated PNGs with both metadata types load the workflow, not parameters Fixes issue where large workflows (e.g., 634 nodes) were replaced with basic A1111 format when importing PNG files.

coderabbitai · 2025-12-04T06:28:39Z

📝 Walkthrough

Walkthrough

Refactors file-handling in src/scripts/app.ts: workflows are parsed and processed earlier and now take precedence over parameters; loadGraphData enforces that graphData is a non-null object (not an array) and resets to defaultGraph when invalid; duplicated workflow handling was removed.

Changes

Cohort / File(s)	Summary
Workflow handling & graph data validation `src/scripts/app.ts`	`loadGraphData` now validates `graphData` is a non-null object (not an array) and resets to `defaultGraph` on invalid input; `handleFile` was refactored to parse/process `workflow` early (accepting string or object), return on success/error, and the later duplicated workflow branch was removed so workflow takes precedence over parameters.

Possibly related issues

Adjust the logic in handleFile function of app.ts #6988 — Both change handleFile/loadGraphData to prioritize workflow parsing over parameter parsing and adjust validation.
File handling refactor breaks loading of PNGs with NaN values in metadata #4199 — Both address eager parsing/validation of image/workflow metadata (e.g., NaN or invalid values) by changing workflow handling and validation.
Loading workflows from image fails #6633 — This PR’s earlier workflow-first parsing and stricter graphData validation may address failures loading complex workflows from image metadata.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	PR successfully addresses all coding requirements from issue #6633: reorders workflow processing to prioritize workflows over parameters, adds explicit JSON parse error handling, fixes loadGraphData() type validation, and treats parameters as fallback.
Out of Scope Changes check	✅ Passed	All changes in src/scripts/app.ts are directly scoped to fixing workflow loading from image metadata, with no unrelated modifications detected.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 849bdc1 and 3689d05.

📒 Files selected for processing (1)

src/scripts/app.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursorrules)

Use es-toolkit for utility functions

Files:

src/scripts/app.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

Use TypeScript for type safety

**/*.{ts,tsx}: Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

src/scripts/app.ts

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

src/scripts/app.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

src/scripts/app.ts

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
Use defaultsByInstallVersion property for gradual feature rollout based on version in settings configuration

Files:

src/scripts/app.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

src/scripts/app.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/scripts/app.ts

🧠 Learnings (4)

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

src/scripts/app.ts

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : When writing methods, prefer returning idiomatic JavaScript `undefined` over `null`

Applied to files:

src/scripts/app.ts

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Implement proper error handling

Applied to files:

src/scripts/app.ts

📚 Learning: 2025-11-24T19:46:52.279Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T19:46:52.279Z
Learning: Applies to **/*.{ts,tsx,js,vue} : Implement proper error handling in components and services

Applied to files:

src/scripts/app.ts

🧬 Code graph analysis (1)

src/scripts/app.ts (2)

src/stores/queueStore.ts (1)

workflow (314-316)

src/platform/workflow/validation/schemas/workflowSchema.ts (1)

ComfyWorkflowJSON (460-462)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-04T06:28:44Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/04/2025, 04:47:17 PM UTC

📈 Summary

Total Tests: 494
Passed: 480 ✅
Failed: 0
Flaky: 4 ⚠️
Skipped: 10 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 471 / ❌ 0 / ⚠️ 4 / ⏭️ 10
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

github-actions · 2025-12-04T06:28:46Z

🎨 Storybook Build Status

Build is starting...

⏰ Started at: 12/04/2025, 04:36:14 PM UTC

🚀 Building Storybook

📦 Installing dependencies...
🔧 Building Storybook components...
🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

Copilot

Pull request overview

This PR fixes a critical issue where PNG files containing both workflow and parameters metadata (commonly generated by ComfyUI) would incorrectly load the A1111 format parameters instead of the full workflow, resulting in data loss for large workflows.

Key changes:

Reordered metadata checks in handleFile() to prioritize workflow over parameters
Added JSON parsing error handling and validation for workflow objects
Enhanced type validation in loadGraphData() to prevent replacing valid falsy values

Comments suppressed due to low confidence (1)

src/scripts/app.ts:1488

The prompt handling (line 1485) lacks error handling for JSON parsing, unlike the improved workflow handling above. If prompt is a string containing invalid JSON, JSON.parse(prompt) will throw an uncaught error and crash the import process.

Consider adding similar try-catch error handling:

if (prompt) {
  let promptObj
  try {
    promptObj = typeof prompt === 'string' ? JSON.parse(prompt) : prompt
  } catch (err) {
    console.error('Failed to parse prompt:', err)
    this.showErrorOnFileLoad(file)
    return
  }
  this.loadApiJson(promptObj, fileName)
  return
}

    if (prompt) {
      const promptObj = typeof prompt === 'string' ? JSON.parse(prompt) : prompt
      this.loadApiJson(promptObj, fileName)
      return
    }

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d4a6df and 3dd77ca.

📒 Files selected for processing (1)

src/scripts/app.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursorrules)

Use es-toolkit for utility functions

Files:

src/scripts/app.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

Use TypeScript for type safety

**/*.{ts,tsx}: Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

src/scripts/app.ts

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

src/scripts/app.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

src/scripts/app.ts

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
Use defaultsByInstallVersion property for gradual feature rollout based on version in settings configuration

Files:

src/scripts/app.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

src/scripts/app.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/scripts/app.ts

🧬 Code graph analysis (1)

src/scripts/app.ts (2)

src/stores/queueStore.ts (1)

workflow (314-316)

src/platform/workflow/validation/schemas/workflowSchema.ts (1)

ComfyWorkflowJSON (460-462)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Agent
GitHub Check: CodeQL analysis (javascript-typescript)

🔇 Additional comments (2)

src/scripts/app.ts (2)

1441-1469: LGTM! Good fix for workflow priority handling.

The changes correctly ensure workflow metadata takes priority over parameters when both are present in PNG files. The error handling with try-catch for JSON.parse and explicit structure validation provides good robustness against malformed metadata.

1471-1482: LGTM!

Parameters are now correctly used as a fallback when no workflow exists, preserving backward compatibility with A1111-only PNG files.

src/scripts/app.ts

github-actions · 2025-12-04T07:17:24Z

Bundle Size Report

Summary

Raw size: 17 MB baseline 17 MB — 🔴 +489 B
Gzip: 3.38 MB baseline 3.38 MB — 🔴 +68 B
Brotli: 2.59 MB baseline 2.59 MB — 🟢 -141 B
Bundles: 97 current • 97 baseline • 37 added / 37 removed

Category Glance
App Entry Points 🔴 +489 B (3.2 MB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.81 MB) · Graph Workspace ⚪ 0 B (972 kB) · Panels & Settings ⚪ 0 B (298 kB) · UI Components ⚪ 0 B (173 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.2 MB (baseline 3.2 MB) • 🔴 +489 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-CSKSskFm.js (new)	—	2.97 MB	🔴 +2.97 MB	🔴 +619 kB	🔴 +470 kB
~~assets/index-jS2IrUPF.js~~ (removed)	2.97 MB	—	🟢 -2.97 MB	🟢 -619 kB	🟢 -471 kB
~~assets/index-CllzdSSX.js~~ (removed)	223 kB	—	🟢 -223 kB	🟢 -47.6 kB	🟢 -39.3 kB
assets/index-NHxJUH_7.js (new)	—	223 kB	🔴 +223 kB	🔴 +47.6 kB	🔴 +39.3 kB
~~assets/index-B628sgUx.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -245 B	🟢 -213 B
assets/index-DvS-Nvgi.js (new)	—	345 B	🔴 +345 B	🔴 +244 B	🔴 +228 B

Status: 3 added / 3 removed

Graph Workspace — 972 kB (baseline 972 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/GraphView-CkLs0RBC.js (new)	—	972 kB	🔴 +972 kB	🔴 +188 kB	🔴 +143 kB
~~assets/GraphView-CXD_0HAe.js~~ (removed)	972 kB	—	🟢 -972 kB	🟢 -188 kB	🟢 -143 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-CUseebdd.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.9 kB
~~assets/UserSelectView-h3pM1YCe.js~~ (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/CreditsPanel-BIw45xWP.js~~ (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.15 kB	🟢 -4.5 kB
assets/CreditsPanel-DrOVxrRo.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.15 kB	🔴 +4.49 kB
~~assets/KeybindingPanel-9AtFnZRl.js~~ (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.01 kB
assets/KeybindingPanel-DRtPJ29T.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.02 kB
~~assets/ExtensionPanel-CN-JKbSd.js~~ (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.58 kB	🟢 -2.26 kB
assets/ExtensionPanel-PMSQ-ESk.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.26 kB
assets/AboutPanel-BNihIMfS.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.21 kB
~~assets/AboutPanel-Dk7zAXTg.js~~ (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.21 kB
~~assets/ServerConfigPanel-CkVg04B7.js~~ (removed)	6.56 kB	—	🟢 -6.56 kB	🟢 -1.83 kB	🟢 -1.63 kB
assets/ServerConfigPanel-EjR7OAf8.js (new)	—	6.56 kB	🔴 +6.56 kB	🔴 +1.83 kB	🔴 +1.63 kB
~~assets/UserPanel-BzxAG4cH.js~~ (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.72 kB	🟢 -1.51 kB
assets/UserPanel-CZdGia40.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.72 kB	🔴 +1.51 kB
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BXTtSH4O.js	33.3 kB	33.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C9Pzn-NG.js	25.2 kB	25.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CCy2fA_h.js	27.3 kB	27.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CQpqEFfl.js	26.6 kB	26.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DHcnxypw.js	21.7 kB	21.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DhFTK9fY.js	25.1 kB	25.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DlT4t_ui.js	25.9 kB	25.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DRgSrIdD.js	24.2 kB	24.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-tjkeqiZq.js	21.1 kB	21.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 173 kB (baseline 173 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-CdStuJZ4.js (new)	—	53.9 kB	🔴 +53.9 kB	🔴 +8.52 kB	🔴 +7.31 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-XcF-NR1a.js~~ (removed)	53.9 kB	—	🟢 -53.9 kB	🟢 -8.52 kB	🟢 -7.32 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-Cd0OpXyR.js~~ (removed)	47.6 kB	—	🟢 -47.6 kB	🟢 -10.3 kB	🟢 -8.89 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CwVOTfQC.js (new)	—	47.6 kB	🔴 +47.6 kB	🔴 +10.3 kB	🔴 +8.9 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-CUybCEiy.js (new)	—	43.3 kB	🔴 +43.3 kB	🔴 +9.68 kB	🔴 +8.46 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-D-iS1o3l.js~~ (removed)	43.3 kB	—	🟢 -43.3 kB	🟢 -9.68 kB	🟢 -8.46 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-BEM16Xdc.js~~ (removed)	12.9 kB	—	🟢 -12.9 kB	🟢 -3.37 kB	🟢 -2.97 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-SHbOuSnK.js (new)	—	12.9 kB	🔴 +12.9 kB	🔴 +3.37 kB	🔴 +2.96 kB
assets/ComfyQueueButton-BnPqaoQq.js (new)	—	8.44 kB	🔴 +8.44 kB	🔴 +2.47 kB	🔴 +2.21 kB
~~assets/ComfyQueueButton-CjuqY0gm.js~~ (removed)	8.44 kB	—	🟢 -8.44 kB	🟢 -2.47 kB	🟢 -2.21 kB
~~assets/MediaTitle.vue_vue_type_script_setup_true_lang-BYFaMppD.js~~ (removed)	897 B	—	🟢 -897 B	🟢 -502 B	🟢 -460 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CKIYNPjU.js (new)	—	897 B	🔴 +897 B	🔴 +502 B	🔴 +437 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DRxvgpU7.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-DBkWxjh1.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-VhqMWCTd.js	2.16 kB	2.16 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/keybindingService-D1AmmYml.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.58 kB
assets/keybindingService-EDCNXIY5.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.58 kB
assets/audioService-C6FPWKBC.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +960 B	🔴 +826 B
~~assets/audioService-VswIfx__.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -958 B	🟢 -823 B
assets/serverConfigStore-BIb40oOr.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/audioUtils-Cd7cvICv.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -649 B	🟢 -544 B
assets/audioUtils-DutV1joq.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +650 B	🔴 +547 B
assets/mathUtil-CTARWQ-l.js	1.07 kB	1.07 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js	460 B	460 B	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DWRkrNy1.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-BZzgsWym.js	3.98 MB	3.98 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-3gHexYD_.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-aR6ntw5X.js	1.37 MB	1.37 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-Dw558Ulu.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-CoO6TOrn.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BZLod3g9.js	407 kB	407 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/WidgetRecordAudio-BKXUBAhG.js~~ (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.24 kB	🟢 -4.62 kB
assets/WidgetRecordAudio-C0Nwqw4n.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.24 kB	🔴 +4.62 kB
~~assets/AudioPreviewPlayer-DSuxdPYs.js~~ (removed)	13.5 kB	—	🟢 -13.5 kB	🟢 -3.4 kB	🟢 -3.04 kB
assets/AudioPreviewPlayer-xVJw2gjO.js (new)	—	13.5 kB	🔴 +13.5 kB	🔴 +3.4 kB	🔴 +3.04 kB
~~assets/WidgetGalleria-IvkpjJyx.js~~ (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.45 kB	🟢 -1.31 kB
assets/WidgetGalleria-jaCuvoB-.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.44 kB	🔴 +1.3 kB
assets/WidgetColorPicker-BtLydAu4.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
~~assets/WidgetColorPicker-BWWwXIVh.js~~ (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
assets/WidgetMarkdown-C9AOTn7j.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.12 kB
~~assets/WidgetMarkdown-DlK67iLh.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.12 kB
~~assets/WidgetAudioUI-BvtICMkj.js~~ (removed)	2.82 kB	—	🟢 -2.82 kB	🟢 -1.12 kB	🟢 -1.02 kB
assets/WidgetAudioUI-DRPxX8__.js (new)	—	2.82 kB	🔴 +2.82 kB	🔴 +1.12 kB	🔴 +1.02 kB
assets/WidgetTextarea-B3AcOiBi.js (new)	—	2.79 kB	🔴 +2.79 kB	🔴 +1.09 kB	🔴 +995 B
~~assets/WidgetTextarea-DGFMxuM_.js~~ (removed)	2.79 kB	—	🟢 -2.79 kB	🟢 -1.09 kB	🟢 -1 kB
~~assets/WidgetInputText-BQ3Pe5d4.js~~ (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -916 B	🟢 -851 B
assets/WidgetInputText-C-bFAZnL.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +916 B	🔴 +845 B
assets/MediaImageBottom-B-r7nS1e.js (new)	—	1.57 kB	🔴 +1.57 kB	🔴 +743 B	🔴 +644 B
~~assets/MediaImageBottom-LKX1PyUM.js~~ (removed)	1.57 kB	—	🟢 -1.57 kB	🟢 -743 B	🟢 -648 B
~~assets/MediaAudioBottom-BZond_Ez.js~~ (removed)	1.52 kB	—	🟢 -1.52 kB	🟢 -740 B	🟢 -658 B
assets/MediaAudioBottom-DrJ0ngnE.js (new)	—	1.52 kB	🔴 +1.52 kB	🔴 +742 B	🔴 +657 B
~~assets/MediaVideoBottom-DokXHEKR.js~~ (removed)	1.52 kB	—	🟢 -1.52 kB	🟢 -739 B	🟢 -657 B
assets/MediaVideoBottom-U53lSfZ-.js (new)	—	1.52 kB	🔴 +1.52 kB	🔴 +740 B	🔴 +653 B
~~assets/Media3DBottom-DcquEn_L.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -730 B	🟢 -650 B
assets/Media3DBottom-mjcPldao.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +731 B	🔴 +646 B
~~assets/Media3DTop-CFsAyJml.js~~ (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -766 B	🟢 -654 B
assets/Media3DTop-D4PPaU6O.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +765 B	🔴 +650 B
assets/WidgetSelect-BoI0JBPB.js (new)	—	655 B	🔴 +655 B	🔴 +343 B	🔴 +287 B
~~assets/WidgetSelect-Cq1efJI1.js~~ (removed)	655 B	—	🟢 -655 B	🟢 -344 B	🟢 -289 B
~~assets/WidgetInputNumber-D9l4G2Fc.js~~ (removed)	595 B	—	🟢 -595 B	🟢 -329 B	🟢 -278 B
assets/WidgetInputNumber-DDnOfoeU.js (new)	—	595 B	🔴 +595 B	🔴 +329 B	🔴 +280 B
assets/Load3D-BMeAPnse.js (new)	—	424 B	🔴 +424 B	🔴 +266 B	🔴 +226 B
~~assets/Load3D-CgVc_5u_.js~~ (removed)	424 B	—	🟢 -424 B	🟢 -267 B	🟢 -224 B
~~assets/WidgetLegacy-BKKVCKf3.js~~ (removed)	364 B	—	🟢 -364 B	🟢 -238 B	🟢 -231 B
assets/WidgetLegacy-Chgmzg_j.js (new)	—	364 B	🔴 +364 B	🔴 +236 B	🔴 +194 B
assets/commands-_s-RvhJR.js	13.6 kB	13.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BuUILW6P.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BV4R6fLx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CLwPdnT6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CWMchBmd.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DazTQhtc.js	12.9 kB	12.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DmWrOe93.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwiH7Kr6.js	13.8 kB	13.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-mS3LCNPn.js	14.5 kB	14.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B1JflQcI.js	72.2 kB	72.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B2lyXe48.js	114 kB	114 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-B9XEQ-pc.js	94 kB	94 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BErKFzc-.js	73.1 kB	73.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Bf7Tze-u.js	83.4 kB	83.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BhGMcO4Q.js	84.3 kB	84.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CPZUloNQ.js	99 kB	99 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dva0z-T2.js	86.5 kB	86.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-un0K9wDS.js	81.8 kB	81.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-DX0t5RN3.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BN0aEMtg.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BpvqEylZ.js	2.76 kB	2.76 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-8e6QYQW0.js	283 kB	283 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-A_9dx4yn.js	304 kB	304 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BbD3HDi7.js	307 kB	307 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BOJhIPft.js	369 kB	369 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-C-Pw33mW.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-ChLyG0UJ.js	285 kB	285 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CUVPxA4l.js	342 kB	342 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dx5Y4xrW.js	310 kB	310 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JqO5mNmW.js	306 kB	306 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-DsbKXC7D.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-nVNi67CU.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetToggleSwitch-DkvdXJVp.js	1.58 kB	1.58 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 17 added / 17 removed

Co-authored-by: Alexander Brown <DrJKL0424@gmail.com>

Refactor workflow object handling to allow undefined type and improve validation checks.

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

src/scripts/app.ts (1)
1060-1066: Comment incorrectly describes JS falsy values; clarify intent of validation

Empty objects {} are truthy in JavaScript, so the current comment is misleading. The intent here is to ensure graphData is a non-null object (and not a primitive or array), not to preserve “falsy” values.

Consider updating the comment to something like:
-    // Use explicit validation instead of falsy check to avoid replacing
-    // valid but falsy values (empty objects, 0, false, etc.)
+    // Use explicit validation instead of a generic falsy check to ensure
+    // graphData is a plain object (not null, undefined, a primitive, or an
+    // array)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d14ddcb and 849bdc1.

📒 Files selected for processing (1)

src/scripts/app.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursorrules)

Use es-toolkit for utility functions

Files:

src/scripts/app.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

Use TypeScript for type safety

**/*.{ts,tsx}: Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

src/scripts/app.ts

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/scripts/app.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

src/scripts/app.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

src/scripts/app.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

src/scripts/app.ts

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
Use defaultsByInstallVersion property for gradual feature rollout based on version in settings configuration

Files:

src/scripts/app.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

src/scripts/app.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/scripts/app.ts

🧠 Learnings (2)

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

src/scripts/app.ts

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : When writing methods, prefer returning idiomatic JavaScript `undefined` over `null`

Applied to files:

src/scripts/app.ts

🧬 Code graph analysis (1)

src/scripts/app.ts (2)

src/stores/queueStore.ts (1)

workflow (314-316)

src/platform/workflow/validation/schemas/workflowSchema.ts (1)

ComfyWorkflowJSON (460-462)

src/scripts/app.ts

…s metadata - Reorder handleFile() to check workflow before parameters - Add validation to prevent JSON parse errors from crashing imports, fallback to parameters or prompt - Fix loadGraphData() to use explicit type validation instead of falsy check - Ensures ComfyUI-generated PNGs with both metadata types load the workflow, not parameters Fixes issue where large workflows (e.g., 634 nodes) were replaced with basic A1111 format when importing PNG files.

mirabarukaso · 2025-12-06T16:47:15Z

The parameters section should under prompt

The API workflow uses prompt to stroge workflow because we don't care about node position.

Otherwise, it won't fully fix for API generated.

#7154) …s metadata - Reorder handleFile() to check workflow before parameters - Add validation to prevent JSON parse errors from crashing imports - Fix loadGraphData() to use explicit type validation instead of falsy check - Ensures ComfyUI-generated PNGs with both metadata types load the workflow, not parameters Fixes issue where large workflows (e.g., 634 nodes) were replaced with basic A1111 format when importing PNG files. ## Summary Fixed workflow loading from PNG images to prioritize workflow metadata over parameters, preventing large workflows from being replaced with basic A1111 format. ## Changes - **What**: Reordered `handleFile()` to check workflow before parameters, added JSON parse error handling and validation, fixed `loadGraphData()` to use explicit type checking instead of falsy check - **Dependencies**: None ## Review Focus The key issue was in `handleFile()` where parameters were checked before workflow, causing ComfyUI-generated PNGs (which contain both workflow and parameters metadata) to incorrectly import as A1111 format. The fix ensures: 1. Workflow is always checked first and validated properly 2. Parameters are only used as a fallback when no workflow exists 3. Invalid/malformed workflow data doesn't crash the import process Additionally, `loadGraphData()` was using a falsy check (`if (!graphData)`) which could incorrectly replace valid but falsy values. Now uses explicit type validation. Tested with real-world PNG containing 634-node workflow (780KB) + parameters (1KB) - now correctly loads the workflow instead of discarding it.  ## Screenshots (if applicable) N/A - Backend logic fix, no UI changes Fixes #6633 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7154-Fix-workflow-loading-from-PNG-images-with-both-workflow-and-parameter-2bf6d73d365081ecb7a6c4bf6b6ccd51) by [Unito](https://www.unito.io) --------- Co-authored-by: Alexander Brown <DrJKL0424@gmail.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>

comfy-pr-bot · 2025-12-09T00:54:23Z

@r-vage Successfully backported to #7265

…orkflow and parameter… (#7265) Backport of #7154 to `core/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7265-backport-core-1-33-Fix-workflow-loading-from-PNG-images-with-both-workflow-and-paramete-2c46d73d365081e2b6f2dcbec3f2ba04) by [Unito](https://www.unito.io) --------- Co-authored-by: Rvage <skentler@protonmail.com> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: GitHub Action <action@github.com>

Copilot AI review requested due to automatic review settings December 4, 2025 06:28

r-vage requested a review from a team as a code owner December 4, 2025 06:28

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 4, 2025

Copilot started reviewing on behalf of r-vage December 4, 2025 06:28 View session

Copilot finished reviewing on behalf of r-vage December 4, 2025 06:30

Copilot AI reviewed Dec 4, 2025

View reviewed changes

coderabbitai bot reviewed Dec 4, 2025

View reviewed changes

src/scripts/app.ts Show resolved Hide resolved

christian-byrne assigned DrJKL Dec 4, 2025

DrJKL reviewed Dec 4, 2025

View reviewed changes

src/scripts/app.ts Outdated Show resolved Hide resolved

DrJKL reviewed Dec 4, 2025

View reviewed changes

src/scripts/app.ts Show resolved Hide resolved

Update src/scripts/app.ts

d14ddcb

Co-authored-by: Alexander Brown <DrJKL0424@gmail.com>

DrJKL previously approved these changes Dec 4, 2025

View reviewed changes

DrJKL enabled auto-merge (squash) December 4, 2025 07:57

Update workflow object handling and validation

849bdc1

Refactor workflow object handling to allow undefined type and improve validation checks.

auto-merge was automatically disabled December 4, 2025 08:02
Head branch was pushed to by a user without write access

r-vage dismissed DrJKL’s stale review via 849bdc1 December 4, 2025 08:02

Refactor workflow parsing and validation logic

3689d05

coderabbitai bot reviewed Dec 4, 2025

View reviewed changes

src/scripts/app.ts Show resolved Hide resolved

r-vage and others added 3 commits December 4, 2025 09:15

Merge branch 'main' of https://github.com/r-vage/ComfyUI_frontend

1c4aef1

Merge branch 'main' into main

3a3ab74

DrJKL approved these changes Dec 4, 2025

View reviewed changes

DrJKL merged commit 3feeecc into Comfy-Org:main Dec 4, 2025
27 checks passed

christian-byrne added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Dec 9, 2025

christian-byrne added the core/1.33 Backport PRs for core 1.33 label Dec 9, 2025

comfy-pr-bot mentioned this pull request Dec 9, 2025

[backport core/1.33] Fix workflow loading from PNG images with both workflow and parameter… #7265

Merged

github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Dec 9, 2025

This was referenced Dec 9, 2025

Bump frontend to 1.34 comfyanonymous/ComfyUI#11203

Closed

Adjust the logic in handleFile function of app.ts #6988

Open

fix: loading api-format workflow that contains "paramaters" string #7411

Open

Fix workflow loading from PNG images with both workflow and parameter… #7154

Fix workflow loading from PNG images with both workflow and parameter… #7154

Conversation

r-vage commented Dec 4, 2025 • edited by DrJKL Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Review Focus

Screenshots (if applicable)

Uh oh!

coderabbitai bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related issues

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🚀 Building Storybook

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mirabarukaso commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The parameters section should under prompt

Uh oh!

comfy-pr-bot commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

r-vage commented Dec 4, 2025 •

edited by DrJKL

Loading

coderabbitai bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

mirabarukaso commented Dec 6, 2025 •

edited

Loading